-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
32805: parser: batch some allocations in the scanner r=RaduBerinde a=RaduBerinde The scanner allocates copies of all uppercase identifiers; preallocate a buffer (proportional to the size of the query) to save some of these allocations. Benchmark: ``` name old time/op new time/op delta Parse 33.8µs ± 1% 33.7µs ± 1% ~ (p=0.699 n=6+6) name old alloc/op new alloc/op delta Parse 5.54kB ± 0% 5.68kB ± 0% +2.60% (p=0.002 n=6+6) name old allocs/op new allocs/op delta Parse 92.0 ± 0% 81.0 ± 0% -11.96% (p=0.002 n=6+6) ``` Release note: None 32866: update cloud storage deps r=RaduBerinde a=RaduBerinde Informs #30774. Release note: None googleapis/google-cloud-go@0fd7230...0ebda48 Azure/azure-pipeline-go@7571e8e...b8e3409 aws/aws-sdk-go@ee1f179...ddc06f9 I ran all the ccl tests with `customenv.mk`. The Azure keys are no longer valid, all other tests passed. Co-authored-by: Radu Berinde <radu@cockroachlabs.com>
- Loading branch information
Showing
5 changed files
with
97 additions
and
42 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters