Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
120507: sql: default sql.stats.statement_fingerprint.format_mask to use special flags r=xinhaoz a=xinhaoz Please note only the latest commit should be reviewed. ------------------------ By default `sql.stats.statement_fingerprint.format_mask` is now set to `FmtCollapseLists|FmtConstantsAsUnderscores` to reduce statement fingerprint cardinality due to long constant lists and variations in constant formatting. Note that the default fmt flag for statement fingerprint generation is `FmtHideConstants`. Any flags set with sql.stats.statement_fingerprint.format_mask will be OR'd with `FmtHideConstants`. Closes: #120409 Release note (sql change): Users will see the following changes in their generated statement fingerprints from sql stats: - lists with only literals/placeholders and similar subexpressions are shortened to their first item followed by "__more__", e.g. - constants and placeholders are all replaced with the same character, an underscore `_` ``` SELECT * FROM foo WHERE f IN (1, $1, 1+2) -> SELECT * FROM foo WHERE f IN (_, __more__) ``` 120596: kvcoord: add observability for DistSender circuit breakers r=erikgrinaker a=erikgrinaker **util/circuit: add `error` parameter for `EventHandler.OnReset`** This allows the `OnReset` handler to determine whether the circuit breaker was tripped when reset. This can happen e.g. if an async probe succeeds before the breaker has been tripped. **kvcoord: add DistSender circuit breaker metrics** This patch adds an initial set of DistSender circuit breaker metrics: * distsender.circuit_breaker.replicas.count * distsender.circuit_breaker.replicas.tripped * distsender.circuit_breaker.replicas.tripped_events * distsender.circuit_breaker.replicas.probes.running * distsender.circuit_breaker.replicas.probes.success * distsender.circuit_breaker.replicas.probes.failure * distsender.circuit_breaker.replicas.requests.cancelled * distsender.circuit_breaker.replicas.requests.rejected **kvcoord: annotate DistSender circuit breaker async contexts** **kvcoord: improve DistSender circuit breaker errors** **kvcoord: add logging/tracing for DistSender circuit breakers** By default, only the trip/reset events are logged. vmodule logs yield: ``` I240316 13:07:33.815949 113 kv/kvclient/kvcoord/dist_sender_circuit_breaker.go:899 [T1,Vsystem,n1] 243 launching circuit breaker probe for r68/(n3,s3):3 (tripped=false stall=1.318s error=0s) I240316 13:07:33.816084 4941 kv/kvclient/kvcoord/dist_sender_circuit_breaker.go:811 [T1,Vsystem,n1] 244 sending probe to r68/(n3,s3):3: LeaseInfo [/Table/Max] I240316 13:07:34.816556 4941 kv/kvclient/kvcoord/dist_sender_circuit_breaker.go:813 [T1,Vsystem,n1] 249 probe result from r68/(n3,s3):3: br=<nil> err=ba: LeaseInfo [/Table/Max] RPC error: grpc: context deadline exceeded [code 4/DeadlineExceeded] E240316 13:07:34.816788 4941 kv/kvclient/kvcoord/dist_sender_circuit_breaker.go:873 [T1,Vsystem,n1] 250 r68/(n3,s3):3 circuit breaker tripped: probe timed out: context deadline exceede (stalled for 2.32s, erroring for 0s) E240316 13:07:38.023324 5287 kv/kvclient/kvcoord/dist_sender_circuit_breaker.go:519 [T1,Vsystem,n1] 535 request rejected by tripped circuit breaker for r68/(n3,s3):3: probe timed out: context deadline exceeded I240316 13:07:38.024899 9324 kv/kvclient/kvcoord/dist_sender_circuit_breaker.go:813 [T1,Vsystem,n1] 550 probe result from r68/(n3,s3):3: br=<nil> err=ba: LeaseInfo [/Table/Max] RPC error: grpc: context canceled [code 1/Canceled] I240316 13:07:38.025341 9324 kv/kvclient/kvcoord/dist_sender_circuit_breaker.go:890 [T1,Vsystem,n1] 556 r68/(n3,s3):3 circuit breaker reset I240316 13:07:38.025374 9324 kv/kvclient/kvcoord/dist_sender_circuit_breaker.go:906 [T1,Vsystem,n1] 557 stopping circuit breaker probe for r68/(n3,s3):3 (tripped=false lastRequest=1.344s) ``` Resolves #119916. Epic: none Release note: None **kvcoord: use duration helpers in DistSender circuit breakers** **kvcoord: change DistSender circuit breaker string identifier** Changes e.g. `r68/(n3,s3):3` to `r68/3:(n3,s3)`. 120908: go.mod: bump Pebble to 10ebcdd794ec r=itsbilal a=aadityasondhi Changes: * [`10ebcdd7`](cockroachdb/pebble@10ebcdd7) metamorphic: track IngestAndExcise in keymgr and resolve singledel conflicts * [`b3c1664a`](cockroachdb/pebble@b3c1664a) db: fix nil map error when ingest-splitting during flushable ingests * [`fd5dc141`](cockroachdb/pebble@fd5dc141) metamorphic: re-enable ingest split and ingestAndExcise in TestMeta * [`4335ae09`](cockroachdb/pebble@4335ae09) keyspan: simplify Filter * [`30f455fa`](cockroachdb/pebble@30f455fa) keyspan: simplify and reimplement Truncate * [`e2f53d2d`](cockroachdb/pebble@e2f53d2d) wal: fix recordQueue bug due to forgetting to mod when indexing * [`8cdabcc9`](cockroachdb/pebble@8cdabcc9) metamorphic: add support for external ingestions in replicateOp * [`e5c9f635`](cockroachdb/pebble@e5c9f635) db: remove strictWALTail option * [`3c9893d6`](cockroachdb/pebble@3c9893d6) ingest: fix ingestion metric for flushableIngest * [`8a097e8a`](cockroachdb/pebble@8a097e8a) ingest,compaction: use excise when flushing flushableIngest * [`dc7ccb2b`](cockroachdb/pebble@dc7ccb2b) vfs/vfstest: adjust WithOpenFileTracking to not wrap typed nils * [`c268820f`](cockroachdb/pebble@c268820f) meta: temporarily disable downloadOp * [`2aa3786c`](cockroachdb/pebble@2aa3786c) sstable: split block.go * [`702f8cc3`](cockroachdb/pebble@702f8cc3) base: add UserKeyBounds Release note: none. Epic: none. Co-authored-by: Xin Hao Zhang <xzhang@cockroachlabs.com> Co-authored-by: Erik Grinaker <grinaker@cockroachlabs.com> Co-authored-by: Aaditya Sondhi <20070511+aadityasondhi@users.noreply.github.com>
- Loading branch information
