Skip to content

Commit

Permalink
Makefile: learn that roachtest depends on generated code
Browse files Browse the repository at this point in the history
Since bd821a7 the roachtest command depends on generated code. Teach the
Makefile this.

The Makefile will one day be smart enough to deduce this on its own, but
for now it's simpler to explicitly list the commands that require
generated code. Note that the simple but coarse solution of assuming
that all commands depend on generated code is inviable as some of these
commands are used to generate the code in the first place.

Release note: None
  • Loading branch information
benesch committed Jun 25, 2018
1 parent a9e3a44 commit cd4415c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -1411,7 +1411,7 @@ logictest-package = ./pkg/sql/logictest
logictestccl-package = ./pkg/ccl/logictestccl

# Additional dependencies for binaries that depend on generated code.
bin/workload bin/docgen: $(SQLPARSER_TARGETS) $(PROTOBUF_TARGETS)
bin/workload bin/docgen bin/roachtest: $(SQLPARSER_TARGETS) $(PROTOBUF_TARGETS)

$(bins): bin/%: bin/%.d | bin/prereqs bin/.submodules-initialized
@echo go install -v $*
Expand Down

0 comments on commit cd4415c

Please sign in to comment.