Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jobs details refreshing with executing job #103206

Closed
maryliag opened this issue May 12, 2023 · 1 comment · Fixed by #104981
Closed

jobs details refreshing with executing job #103206

maryliag opened this issue May 12, 2023 · 1 comment · Fixed by #104981
Assignees
@gtr
Labels
A-cluster-observability Related to cluster observability C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@maryliag
Copy link
Contributor

maryliag commented May 12, 2023 •
edited by cockroach-jira-scripts
Loading

When a job is still being executed we want to keep refreshing the details endpoint to get the data, but that refresh should be done in the background, without interfering with results already displayed.
Currently when the new refresh starts the pages goes back to a loading state
example: https://www.loom.com/share/1824befa84a04a0891e1163226f0a4eeza

Jira issue: CRDB-27885
@maryliag maryliag added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-cluster-observability A-cluster-observability Related to cluster observability labels May 12, 2023
@blathers-crl blathers-crl bot added this to Triage in Cluster Observability May 12, 2023
@maryliag maryliag moved this from Triage to Bugs in Cluster Observability May 15, 2023
@gtr gtr self-assigned this May 31, 2023
@xinhaoz
Copy link
Member

xinhaoz commented Jun 15, 2023 •
edited
Loading

Shoot, my bad. I introduced this by accident in this PR: 9d64c7f#diff-09da33ea6445e45b3297128512a6c0fad08b57b3d2e44396a0265dea5e9e1b62L168.
We need to add the && !this.props.jobRequest.data to the isLoading declaration.

Edit: wait, nvm didnt see it was also an or before, so It's been happening since before that too in case we need to backport to the those versions. Anywho the fix is the same though.

@gtr gtr mentioned this issue Jun 15, 2023
Merged
craig bot pushed a commit that referenced this issue Jun 15, 2023
@gtr
Merge #104981
26fdd4e 
104981: ui: fix job details refresh when executing job r=gtr a=gtr

Fixes: #103206

Previously, when a job was still executing, the job details page for that job would keep refreshing and the loading animation would interrupt the page, causing flickers. This commit fixes this bug to only show the loading animation when the `jobRequest` does not have data to show.

Loom: https://www.loom.com/share/498f5cfd236e4bb6aeaf9f27e9e5409b.

Release note (ui change): fix bug where the job details page would flicker between the job details and a loading animation when a job is still executing.

Co-authored-by: gtr <gerardo@cockroachlabs.com>
@craig craig bot closed this as completed in feca697 Jun 15, 2023
Cluster Observability automation moved this from Bugs to Done Jun 15, 2023
@gtr gtr mentioned this issue Jul 5, 2023
Merged
gtr added a commit to gtr/cockroach that referenced this issue Jul 5, 2023
@gtr
ui: fix job details refresh when executing job
582e55d 
Fixes: cockroachdb#103206

Previously, when a job was still executing, the job details page for
that job would keep refreshing and the loading animation would interrupt
the page, causing flickers. This commit fixes this bug to only show the
loading animation when the `jobRequest` does not have data to show.

Release note (ui change): fix bug where the job details page would
flicker between the job details and a loading animation when a job is
still executing.
@gtr gtr mentioned this issue Jul 5, 2023
Merged
gtr added a commit to gtr/cockroach that referenced this issue Jul 5, 2023
@gtr
ui: fix job details refresh when executing job
64a8f0e 
Fixes: cockroachdb#103206

Previously, when a job was still executing, the job details page for
that job would keep refreshing and the loading animation would interrupt
the page, causing flickers. This commit fixes this bug to only show the
loading animation when the `jobRequest` does not have data to show.

Release note (ui change): fix bug where the job details page would
flicker between the job details and a loading animation when a job is
still executing.
gtr added a commit to gtr/cockroach that referenced this issue Jul 7, 2023
@gtr
ui: fix job details refresh when executing job
510a37d 
Fixes: cockroachdb#103206

Previously, when a job was still executing, the job details page for
that job would keep refreshing and the loading animation would interrupt
the page, causing flickers. This commit fixes this bug to only show the
loading animation when the `jobRequest` does not have data to show.

Release note (ui change): fix bug where the job details page would
flicker between the job details and a loading animation when a job is
still executing.
gtr added a commit to gtr/cockroach that referenced this issue Jul 7, 2023
@gtr
ui: fix job details refresh when executing job
735c93e 
Fixes: cockroachdb#103206

Previously, when a job was still executing, the job details page for
that job would keep refreshing and the loading animation would interrupt
the page, causing flickers. This commit fixes this bug to only show the
loading animation when the `jobRequest` does not have data to show.

Release note (ui change): fix bug where the job details page would
flicker between the job details and a loading animation when a job is
still executing.
maryliag pushed a commit that referenced this issue Jul 24, 2023
@gtr @maryliag
ui: fix job details refresh when executing job
3de7397 
Fixes: #103206

Previously, when a job was still executing, the job details page for
that job would keep refreshing and the loading animation would interrupt
the page, causing flickers. This commit fixes this bug to only show the
loading animation when the `jobRequest` does not have data to show.

Release note (ui change): fix bug where the job details page would
flicker between the job details and a loading animation when a job is
still executing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gtr gtr

Labels
A-cluster-observability Related to cluster observability C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ui: fix job details refresh when executing job gtr/cockroach
3 participants
@maryliag @xinhaoz @gtr