ui: fix job details refresh when executing job #104981
Conversation
|
This change is |
gtr
added
backport-22.1.x
backport-23.1.x
Fixes: cockroachdb#103206 Previously, when a job was still executing, the job details page for that job would keep refreshing and the loading animation would interrupt the page, causing flickers. This commit fixes this bug to only show the loading animation when the `jobRequest` does not have data to show. Release note (ui change): fix bug where the job details page would flicker between the job details and a loading animation when a job is still executing.
gtr
force-pushed
the
job-details-refresh-bug
branch
from
c013bd4
to
feca697
Compare
|
Looks like that |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from feca697 to blathers/backport-release-22.2-104981: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.2.x failed. See errors above. error creating merge commit from feca697 to blathers/backport-release-23.1-104981: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained
-- commits line 11 at r1:
nit: this is not a ui change, this category should be a "bug fix"
Fixes: #103206
Previously, when a job was still executing, the job details page for that job would keep refreshing and the loading animation would interrupt the page, causing flickers. This commit fixes this bug to only show the loading animation when the
jobRequestdoes not have data to show.Loom: https://www.loom.com/share/498f5cfd236e4bb6aeaf9f27e9e5409b.
Release note (ui change): fix bug where the job details page would flicker between the job details and a loading animation when a job is still executing.