Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links on Used Indexes column on Statement Fingerprint Details, Explain Plan tab are broken #103595

Closed
florence-crl opened this issue May 18, 2023 · 3 comments
Assignees
Labels
A-cluster-observability Related to cluster observability C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@florence-crl
Copy link

florence-crl commented May 18, 2023

Describe the problem

PR 92463 added the Used Indexes column to the Statement Fingerprint Details page with links to the table or index details pages. However, the link to the table details page gives an error and the link to the index details page does not give data.

To Reproduce

For example,
"Good" path:
If you go to the index rides.rides_pkey via Databases > Tables > Table: "public"."rides" > Index: rides_pkey, you go to the following "good" url which gives data:
http://localhost:8080/#/database/movr/table/%22public%22.%22rides%22/index/rides_pkey

"Bad" path:
While if you click on the index from the Statement fingerprint details page, Explain Plan tab, from the Used Indexes column, you go to the following "bad" url which gives no data:
http://localhost:8080/#/database/[%22movr%22]/table/rides/index/rides_pkey
The bread crumb path shows: Databases > Tables > Table:rides > Index: rides_pkey.

Also if you click on the table, you go the following "bad" url which gives an error:
http://localhost:8080/#/database/[%22movr%22]/table/rides
This page had an unexpected error while loading databases. Reload this page

Expected behavior
From the Used Indexes column, the links to the table and index details pages gives same data as going from the Databases link on the left nav menu.

Environment:

  • CockroachDB version: 23.1.1
  • Server OS: Mac
  • Client app: DB Console

Jira issue: CRDB-28092

@florence-crl florence-crl added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label May 18, 2023
@florence-crl
Copy link
Author

In 23.1.4, from the Used Indexes column, the links to the table and index details pages gives same data as going from the Databases link on the left nav menu. For example,

The links from the Used Indexes column look like:
http://localhost:8080/#/database/movr/table/user_promo_codes
http://localhost:8080/#/database/movr/table/user_promo_codes/index/user_promo_codes_pkey

while the the links from the Databases link on the left nav menu look like:
http://localhost:8080/#/database/movr/table/%22public%22.%22user_promo_codes%22
http://localhost:8080/#/database/movr/table/%22public%22.%22user_promo_codes%22/index/user_promo_codes_pkey

Closing this issue.

@florence-crl
Copy link
Author

florence-crl commented Jun 22, 2023

In 23.1.4, the issue has re-appeared with table or index url having ["<database name>"] causing page errors.

@xinhaoz xinhaoz self-assigned this Jul 6, 2023
@xinhaoz
Copy link
Member

xinhaoz commented Jul 17, 2023

This was fixed by #105351.
The links use the database name from the metadata column, which was previously using the incorrect aggregate function when reading from the activity table.

@xinhaoz xinhaoz closed this as completed Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cluster-observability Related to cluster observability C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Development

No branches or pull requests

2 participants