ui: overview page email signup missing background color #105740
Labels
A-cluster-observability
Related to cluster observability
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
E-quick-win
Likely to be a quick win for someone experienced.
Projects
Comments
j82w
added
C-bug
sudomateo
added a commit
to sudomateo/cockroachdb-cockroach
that referenced
this issue
Nov 16, 2023
Previously, the styling for the `crl-email-subscription` CSS class would render white text on a white background when the background image failed to load. This made it difficult to read what the call to action was. This patch removes the `background-image` property from the `crl-email-subscription` CSS class and instead configures the class to render black text on a white background. Fixes: cockroachdb#105740 Part of: CRDB-29170 Release note (ui change): The overview page now correctly renders the background color for the email signup, fixing an issue where it was difficult to read the text within.
sudomateo
added a commit
to sudomateo/cockroachdb-cockroach
that referenced
this issue
Nov 16, 2023
Previously, when the background image failed to load for the `crl-email-subscription` CSS class it would render render white text on a white background, making it difficult to read the call to action. This patch removes the background image from the `crl-email-subscription` CSS class and instead configures the class to render black text on a white background. Fixes: cockroachdb#105740 Part of: CRDB-29170 Release note (ui change): The overview page now correctly renders the background color for the email signup, fixing an issue where it was difficult to read the text.
craig bot
pushed a commit
that referenced
this issue
Nov 16, 2023
114538: ui: update `crl-email-subscription` styling r=sudomateo a=sudomateo Previously, when the background image failed to load for the `crl-email-subscription` CSS class it would render render white text on a white background, making it difficult to read the call to action. This patch adds the `background-color` property to the `crl-email-subscription` CSS class so that it is used when the background image fails to load. Fixes: #105740 Part of: CRDB-29170 Release note (ui change): The overview page now correctly renders the background color for the email signup, fixing an issue where it was difficult to read the text. Co-authored-by: Matthew Sanabria <24284972+sudomateo@users.noreply.github.com>
blathers-crl bot
pushed a commit
that referenced
this issue
Nov 16, 2023
Previously, when the background image failed to load for the `crl-email-subscription` CSS class it would render render white text on a white background, making it difficult to read the call to action. This patch adds the `background-color` property to the `crl-email-subscription` CSS class so that it is used when the background image fails to load. Fixes: #105740 Part of: CRDB-29170 Release note (ui change): The overview page now correctly renders the background color for the email signup, fixing an issue where it was difficult to read the text.
blathers-crl bot
pushed a commit
that referenced
this issue
Nov 16, 2023
Previously, when the background image failed to load for the `crl-email-subscription` CSS class it would render render white text on a white background, making it difficult to read the call to action. This patch adds the `background-color` property to the `crl-email-subscription` CSS class so that it is used when the background image fails to load. Fixes: #105740 Part of: CRDB-29170 Release note (ui change): The overview page now correctly renders the background color for the email signup, fixing an issue where it was difficult to read the text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There is text above the capacity usage
Keep up-to-date with CockroachDB software releases and best practices.that is very hard to read. It seems like the background color is missing for the overview page.Jira issue: CRDB-29170
The text was updated successfully, but these errors were encountered: