-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.1: ui: update crl-email-subscription
styling
#114546
Conversation
Previously, when the background image failed to load for the `crl-email-subscription` CSS class it would render render white text on a white background, making it difficult to read the call to action. This patch adds the `background-color` property to the `crl-email-subscription` CSS class so that it is used when the background image fails to load. Fixes: #105740 Part of: CRDB-29170 Release note (ui change): The overview page now correctly renders the background color for the email signup, fixing an issue where it was difficult to read the text.
0c43ef7
to
01545f8
Compare
d9c68af
to
fe5f3b5
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
@dhartunian @maryliag, does this PR fix a "serious issue" as per the policy (https://cockroachlabs.atlassian.net/wiki/spaces/ENG/pages/1043235321/Database+Backport+Patch+Policy#Getting-your-backport-reviewed)?
|
@joshimhoff I'd say in terms of the size of diff to impact ratio, making the first page of the DB Console not look terrible is "serious" enough to merge this. |
Agree with David here, not being able to read a text it serious enough. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Backport 1/1 commits from #114538 on behalf of @sudomateo.
/cc @cockroachdb/release
Previously, when the background image failed to load for the
crl-email-subscription
CSS class it would render render white text ona white background, making it difficult to read the call to action.
This patch adds the
background-color
property to thecrl-email-subscription
CSS class so that it is used when thebackground image fails to load.
Fixes: #105740
Part of: CRDB-29170
Release note (ui change): The overview page now correctly renders the
background color for the email signup, fixing an issue where it was
difficult to read the text.
Release justification: Fixed a UI issue preventing users from reading the email subscription call-to-action.