Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: ui: update crl-email-subscription styling #114546

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Nov 16, 2023

Backport 1/1 commits from #114538 on behalf of @sudomateo.

/cc @cockroachdb/release


Previously, when the background image failed to load for the
crl-email-subscription CSS class it would render render white text on
a white background, making it difficult to read the call to action.

This patch adds the background-color property to the
crl-email-subscription CSS class so that it is used when the
background image fails to load.

Fixes: #105740
Part of: CRDB-29170

Release note (ui change): The overview page now correctly renders the
background color for the email signup, fixing an issue where it was
difficult to read the text.


Release justification: Fixed a UI issue preventing users from reading the email subscription call-to-action.

Previously, when the background image failed to load for the
`crl-email-subscription` CSS class it would render render white text on
a white background, making it difficult to read the call to action.

This patch adds the `background-color` property to the
`crl-email-subscription` CSS class so that it is used when the
background image fails to load.

Fixes: #105740
Part of: CRDB-29170

Release note (ui change): The overview page now correctly renders the
background color for the email signup, fixing an issue where it was
difficult to read the text.
@blathers-crl blathers-crl bot requested a review from a team November 16, 2023 02:39
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-114538 branch from 0c43ef7 to 01545f8 Compare November 16, 2023 02:39
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Nov 16, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-114538 branch from d9c68af to fe5f3b5 Compare November 16, 2023 02:39
Copy link
Author

blathers-crl bot commented Nov 16, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Nov 16, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@dhartunian dhartunian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@joshimhoff
Copy link
Collaborator

@dhartunian @maryliag, does this PR fix a "serious issue" as per the policy (https://cockroachlabs.atlassian.net/wiki/spaces/ENG/pages/1043235321/Database+Backport+Patch+Policy#Getting-your-backport-reviewed)?

Backports should only be created for serious
issues or test-only changes.

@dhartunian
Copy link
Collaborator

@joshimhoff I'd say in terms of the size of diff to impact ratio, making the first page of the DB Console not look terrible is "serious" enough to merge this.

@maryliag
Copy link
Contributor

Agree with David here, not being able to read a text it serious enough.

Copy link
Collaborator

@joshimhoff joshimhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sudomateo sudomateo merged commit 8e37ac1 into release-23.1 Nov 20, 2023
6 checks passed
@sudomateo sudomateo deleted the blathers/backport-release-23.1-114538 branch November 20, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants