Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: refresh nodes on databases page #106697

Closed
THardy98 opened this issue Jul 12, 2023 · 0 comments
Closed

ui: refresh nodes on databases page #106697

THardy98 opened this issue Jul 12, 2023 · 0 comments
Assignees
@THardy98
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. O-support Originated from a customer
Projects
Cluster Observability

Comments

@THardy98
Copy link
Contributor

THardy98 commented Jul 12, 2023 •
edited

CockroachDB Version: v22.2.9

We need to refresh the nodes information on the databases page to reflect changes to the nodes' status. In the case of the support ticket that originated this, decommissioned nodes.

Screenshot 2023-07-12 at 1 36 44 PM
Screenshot 2023-07-12 at 1 37 00 PM

From the images above we can see that node 17 is decommissioned but still displays on the UI.

Jira issue: CRDB-29683
@THardy98 THardy98 added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-cluster-observability C-escalation-improvement Having this feature would have made an escalation easier labels Jul 12, 2023
@THardy98 THardy98 self-assigned this Jul 12, 2023
@blathers-crl blathers-crl bot added this to Triage in Cluster Observability Jul 12, 2023
@THardy98 THardy98 moved this from Triage to Active Issues in Cluster Observability Jul 12, 2023
@THardy98 THardy98 added O-support Originated from a customer and removed C-escalation-improvement Having this feature would have made an escalation easier labels Jul 12, 2023
This was referenced Jul 13, 2023
Merged
Merged
craig bot pushed a commit that referenced this issue Jul 17, 2023
@THardy98
Merge #106778
26456a8 
106778: cluster-ui: skip undefined regions on database pages r=THardy98 a=THardy98

Epic: None
Addresses: #106697

This patch skips `undefined` regions on the databases pages. The `undefined` behaviour occurs when we try to match a database's node IDs (i.e. the nodes with ranges that contain data belong to one of the database's tables) from the database details endpoint, to nodes' region information from the nodes endpoint.

The nodes endpoint is authoritative and is refreshed at a regular interval. However, the database details endpoint is only fetched once on page load, and it's node information comes from a cache, leading to the potential of stale data (this information is authoritative in 23.1, but not in 22.2).

Consequently when trying to match cached node IDs with recent node regions information, we can come across behaviour where we try to get region information for a node ID that is no longer valid (i.e. in the case of a decommissioned node), resulting in `undefined` and surfacing outdated node information.

This change ensures that when we encounter such occurrences, we avoid displaying them in the console.

Release note (bug fix): Avoid displaying `undefined` regions on the databases pages.

Co-authored-by: Thomas Hardy <thardy@cockroachlabs.com>
Cluster Observability automation moved this from Active Issues to Done Jul 18, 2023
@THardy98 THardy98 mentioned this issue Sep 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@THardy98 THardy98

Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. O-support Originated from a customer
Projects
No open projects
Cluster Observability
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@THardy98