cluster-ui: skip undefined regions on database pages #106778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
xinhaoz
reviewed
Jul 13, 2023
| @@ -54,7 +54,7 @@ describe("Getting nodes by region string", () => { | |||
| const nodes = [1, 2, 3]; | |||
| const regions = {}; | |||
| const result = getNodesByRegionString(nodes, regions, false); | |||
| assert.deepStrictEqual(result, `undefined(n1,n2,n3)`); | |||
| assert.deepStrictEqual(result, ""); | |||
| @@ -99,6 +99,10 @@ export function createNodesByRegionMap( | |||
| ): Record<string, number[]> { | |||
| const nodesByRegionMap: Record<string, number[]> = {}; | |||
| nodes.forEach((node: number) => { | |||
| // If the node's region doesn't exist skip it. | |||
| if (nodeRegions[node.toString()] === undefined) { | |||
There was a problem hiding this comment.
Do we specifically want to check for undefined or do we want to expand to a nullish check?
There was a problem hiding this comment.
nullish check would be better
THardy98
force-pushed
the
skip_undefined_regions_master
branch
from
bddfa32
to
2f4a43b
Compare
THardy98
force-pushed
the
skip_undefined_regions_master
branch
from
2f4a43b
to
ef5ebbd
Compare
This patch skips `undefined` regions on the databases pages. The `undefined` behaviour occurs when we try to match a database's node IDs (i.e. the nodes with ranges that contain data belong to one of the database's tables) from the database details endpoint, to nodes' region information from the nodes endpoint. The nodes endpoint is authoritative and is refreshed at a regular interval. However, the database details endpoint is only fetched once on page load, and it's node information comes from a cache, leading to the potential of stale data (this information is authoritative in 23.1, but not in 22.2). Consequently when trying to match cached node IDs with recent node regions information, we can come across behaviour where we try to get region information for a node ID that is no longer valid (i.e. in the case of a decommissioned node), resulting in `undefined` and surfacing outdated node information. This change ensures that when we encounter such occurrences, we avoid displaying them in the console. Release note (bug fix): Avoid displaying `undefined` regions on the databases pages.
THardy98
force-pushed
the
skip_undefined_regions_master
branch
from
ef5ebbd
to
cba8f3e
Compare
maryliag
approved these changes
Jul 17, 2023
There was a problem hiding this comment.
Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @xinhaoz)
|
bors r+ |
|
Build succeeded: |
This was referenced Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Epic: None
Addresses: #106697
This patch skips
undefinedregions on the databases pages. Theundefinedbehaviour occurs when we try to match a database's node IDs (i.e. the nodes with ranges that contain data belong to one of the database's tables) from the database details endpoint, to nodes' region information from the nodes endpoint.The nodes endpoint is authoritative and is refreshed at a regular interval. However, the database details endpoint is only fetched once on page load, and it's node information comes from a cache, leading to the potential of stale data (this information is authoritative in 23.1, but not in 22.2).
Consequently when trying to match cached node IDs with recent node regions information, we can come across behaviour where we try to get region information for a node ID that is no longer valid (i.e. in the case of a decommissioned node), resulting in
undefinedand surfacing outdated node information.This change ensures that when we encounter such occurrences, we avoid displaying them in the console.
Release note (bug fix): Avoid displaying
undefinedregions on the databases pages.