cloud/azure: TestAzureStorageFileImplicitAuth failed #107137
Assignees
Labels
branch-master
Failures on the master branch.
C-test-failure
Broken test (automatically or manually discovered).
O-robot
Originated from a bot.
T-disaster-recovery
Projects
Milestone
Comments
cockroach-teamcity
added
branch-master
craig bot
pushed a commit
that referenced
this issue
Jul 21, 2023
106668: plpgsql: implement tail-call optimization for PLpgSQL routines r=DrewKimball a=DrewKimball
This patch implements tail-call optimization for the nested routine execution that is used to handle PLpgSQL control flow. PLpgSQL sub-routines are always tail calls because they are built as "continuation" functions, so we can always use the optimization for PLpgSQL. Tail-call optimization is only possible if the plan is not distributed (although we may not currently distribute such plans anyway).
The optimization is performed by setting a `deferredRoutineReceiver` field on the planner before planning and running a nested routine. This `deferredRoutineReceiver` allows a routine in tail-call position to send the information needed to evaluate itself to its parent, and then return NULL. Once the parent routine receives the result, it checks whether `deferredRoutineReceiver` received a deferred nested routine, and if so, evaluates it to obtain the actual result.
Given a simple looping function like the following:
```
CREATE FUNCTION f(n INT) RETURNS INT AS $$
DECLARE
i INT := 0;
BEGIN
LOOP
IF i >= n THEN
EXIT;
END IF;
i := i + 1;
END LOOP;
RETURN i;
END
$$ LANGUAGE PLpgSQL;
```
This optimization takes runtime on my machine for `n=100000` from >20m to ~2s.
Informs #105254
Release note: None
107205: cloud: allow parallel running of cloud unit tests r=rhu713 a=rhu713
Append a random uint64 in the paths of cloud unit tests to prevent parallel executions from interfering with each other. This is necessary since these tests now run for all release branches and can run in parallel.
Fixes: #107137
Fixes: #107139
Release note: None
Co-authored-by: Drew Kimball <drewk@cockroachlabs.com>
Co-authored-by: Rui Hu <rui@cockroachlabs.com>
THardy98
pushed a commit
to THardy98/cockroach
that referenced
this issue
Jul 24, 2023
Append a random uint64 in the paths of cloud unit tests to prevent parallel executions from interfering with each other. This is necessary since these tests now run for all release branches and can run in parallel. Fixes: cockroachdb#107137 Fixes: cockroachdb#107139 Release note: None
rhu713
pushed a commit
to rhu713/cockroach
that referenced
this issue
Jul 25, 2023
Append a random uint64 in the paths of cloud unit tests to prevent parallel executions from interfering with each other. This is necessary since these tests now run for all release branches and can run in parallel. Fixes: cockroachdb#107137 Fixes: cockroachdb#107139 Release note: None
rhu713
pushed a commit
to rhu713/cockroach
that referenced
this issue
Jul 25, 2023
Append a random uint64 in the paths of cloud unit tests to prevent parallel executions from interfering with each other. This is necessary since these tests now run for all release branches and can run in parallel. Fixes: cockroachdb#107137 Fixes: cockroachdb#107139 Release note: None
rhu713
pushed a commit
to rhu713/cockroach
that referenced
this issue
Jul 25, 2023
Append a random uint64 in the paths of cloud unit tests to prevent parallel executions from interfering with each other. This is necessary since these tests now run for all release branches and can run in parallel. Fixes: cockroachdb#107137 Fixes: cockroachdb#107139 Release note: None
rhu713
pushed a commit
to rhu713/cockroach
that referenced
this issue
Aug 18, 2023
Append a random uint64 in the paths of cloud unit tests to prevent parallel executions from interfering with each other. This is necessary since these tests now run for all release branches and can run in parallel. Fixes: cockroachdb#107137 Fixes: cockroachdb#107139 Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
cloud/azure.TestAzureStorageFileImplicitAuth failed with artifacts on master @ 06b5ba7888339ed53477ff73f9f3ae77a708ee17:
Help
See also: How To Investigate a Go Test Failure (internal)
This test on roachdash | Improve this report!
Jira issue: CRDB-29907
The text was updated successfully, but these errors were encountered: