Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1.9-rc: cloud: allow parallel running of cloud unit tests #109026

Merged

Conversation

rhu713
Copy link
Contributor

@rhu713 rhu713 commented Aug 18, 2023

Backport 1/1 commits from #107205.

/cc @cockroachdb/release


Append a random uint64 in the paths of cloud unit tests to prevent parallel executions from interfering with each other. This is necessary since these tests now run for all release branches and can run in parallel.

Fixes: #107137
Fixes: #107139

Release note: None

Release justification: test-only change

Append a random uint64 in the paths of cloud unit tests to prevent parallel
executions from interfering with each other. This is necessary since these tests
now run for all release branches and can run in parallel.

Fixes: cockroachdb#107137
Fixes: cockroachdb#107139

Release note: None
@blathers-crl
Copy link

blathers-crl bot commented Aug 18, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rhu713 rhu713 marked this pull request as ready for review August 18, 2023 17:44
@rhu713 rhu713 requested a review from a team as a code owner August 18, 2023 17:44
@rhu713 rhu713 requested review from lidorcarmel and removed request for a team August 18, 2023 17:44
@rhu713 rhu713 merged commit 23a2985 into cockroachdb:release-23.1.9-rc Aug 21, 2023
6 checks passed
@rhu713
Copy link
Contributor Author

rhu713 commented Aug 21, 2023

Fixes #109057

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants