Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schemachanger: Enable CREATE SEQUENCE / SCHEMA #117648

Closed
2 of 3 tasks
Xiang-Gu opened this issue Jan 10, 2024 · 0 comments · Fixed by #120091
Closed
2 of 3 tasks

schemachanger: Enable CREATE SEQUENCE / SCHEMA #117648

Xiang-Gu opened this issue Jan 10, 2024 · 0 comments · Fixed by #120091
Assignees
@fqazi
Labels
A-schema-changer-impl Related to the implementation of the new schema changer branch-master Failures on the master branch. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) GA-blocker P-2 Issues/test failures with a fix SLA of 3 months T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
SQL Foundations

Comments

@Xiang-Gu
Copy link
Contributor

Xiang-Gu commented Jan 10, 2024 •
edited by rafiss

In 23.2 development cycle, we implemented 3 things in the declarative schema changer:

This issue tracks the effort to unfallback those three things in declarative schema changer.

Epic CRDB-31331
Jira issue: CRDB-35289
@Xiang-Gu Xiang-Gu added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) A-schema-changer-impl Related to the implementation of the new schema changer labels Jan 10, 2024
@blathers-crl blathers-crl bot added this to Triage in SQL Foundations Jan 10, 2024
@rafiss rafiss changed the title schemachanger: Enable CREATE SEQUENCE schemachanger: Enable CREATE SEQUENCE / SCHEMA Jan 16, 2024
@fqazi fqazi mentioned this issue Jan 17, 2024
Merged
craig bot pushed a commit that referenced this issue Feb 1, 2024
@fqazi
Merge #117793
420c8b2 
117793: sql/schemachanger: enable declarative CREATE SEQUENCE r=fqazi a=fqazi

Previously, we did fully implement CREATE SEQUENCE in the declarative schema changer but had it disabled by default since we were missing this PR will do the following:

- Enable CREATE SEQUENCE by default in the declarative schema changer
- Add tests for transactionally creating / dropping sequences to confirm that the rules are sound
- Address bugs with transactional creation / drops of relations, since we previously did not create data elements
- Add tests for transactionally adding and using a sequence as a column
- Skip back up and restore tests for newly created objects, since intermediate states are not backed up today (if we do CREATE SEQUENCE and ADD COLUMN in a single txn, we will intentionally not backup the sequence during the job phase)


Informs: #117648
Epic: [CRDB-31282](https://cockroachlabs.atlassian.net/browse/CRDB-31282)

Co-authored-by: Faizan Qazi <faizan@cockroachlabs.com>
@rafiss rafiss added branch-master Failures on the master branch. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Mar 4, 2024
@exalate-issue-sync exalate-issue-sync bot added P-1 Issues/test failures with a fix SLA of 1 month P-2 Issues/test failures with a fix SLA of 3 months and removed P-1 Issues/test failures with a fix SLA of 1 month labels Mar 5, 2024
@rafiss rafiss added GA-blocker and removed release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels Mar 5, 2024
fqazi added a commit to fqazi/cockroach that referenced this issue Mar 8, 2024
@fqazi
sql/schemachanger: CREATE SCHEMA should enforce restrict_system_inter…
0f599d2 
…face

Previously, the declarative CREATE SCHEMA statement ignored the
restrict_system_interface cluster setting. This allowed CREATE SCHEMA
execution within the system tenant, even when it should be disabled.
This patch resolves the issue by enforcing the restrict_system_interface
setting for CREATE SCHEMA.

Informs: cockroachdb#117648

Release note: None
@fqazi fqazi mentioned this issue Mar 8, 2024
Merged
craig bot pushed a commit that referenced this issue Mar 9, 2024
@fqazi
Merge #120091
8fb7310 
120091: sql/schemachanger: enable CREATE SCHEMA in declarative schema changer r=fqazi a=fqazi

This patch enables CREATE SCHEMA in the declarative schema changer and addresses the following issues

1. Enforce restrict_system_interface for the declarative schema changer
2. Fix a dependency issue where other objects could not be created with schemas since the name wasn't populated early enough
3. Update test cases and enable support for CREATE SCHEMA in the declarative schema changer by default.

Fixes: #117648

Co-authored-by: Faizan Qazi <faizan@cockroachlabs.com>
@craig craig bot closed this as completed in bf5254b Mar 9, 2024
SQL Foundations automation moved this from Triage to Done Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fqazi fqazi

Labels
A-schema-changer-impl Related to the implementation of the new schema changer branch-master Failures on the master branch. C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) GA-blocker P-2 Issues/test failures with a fix SLA of 3 months T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
SQL Foundations
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql/schemachanger: enable CREATE SCHEMA in declarative schema changer fqazi/cockroach
3 participants
@rafiss @fqazi @Xiang-Gu