Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ccl/changefeedccl: TestChangefeedWithSimpleDistributionStrategy failed #120870

Closed
cockroach-teamcity opened this issue Mar 22, 2024 · 3 comments · Fixed by #120903
Closed

ccl/changefeedccl: TestChangefeedWithSimpleDistributionStrategy failed #120870

cockroach-teamcity opened this issue Mar 22, 2024 · 3 comments · Fixed by #120903
Assignees
@andyyang890
Labels
A-cdc Change Data Capture A-testing Testing tools and infrastructure branch-master Failures and bugs on the master branch. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-cdc
Milestone
24.1

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented Mar 22, 2024 •
edited by cockroach-jira-scripts

ccl/changefeedccl.TestChangefeedWithSimpleDistributionStrategy failed on master @ c561383c9d86a52cf63a2c8aaa3ee20270635f11:

=== RUN   TestChangefeedWithSimpleDistributionStrategy
    test_log_scope.go:170: test logs captured to: outputs.zip/logTestChangefeedWithSimpleDistributionStrategy1311953055
    test_log_scope.go:81: use -show-logs to present logs inline
    changefeed_dist_test.go:345: found partitions: [{1 /Table/104/1{-/2}, /Table/104/1/{4-5}, /Table/104/1/{7-8}, /Table/104/1/{9-10}, /Table/104/1/1{3-4}, /Table/104/1/1{6-8}, /Table/104/1/{19-20}, /Table/104/1/2{6-7}, /Table/104/1/{28-31}, /Table/104/1/3{2-3} true 14} {4 /Table/104/1/{2-4}, /Table/104/1/{5-7}, /Table/104/1/{8-9}, /Table/104/1/1{0-1}, /Table/104/1/1{2-3}, /Table/104/1/1{5-6}, /Table/104/1/2{1-3}, /Table/104/1/5{8-9} true 11} {2 /Table/104/1/3{3-4}, /Table/104/1/3{6-7}, /Table/104/1/4{3-4}, /Table/104/1/4{6-8}, /Table/104/1/5{0-5}, /Table/104/1/{59-61}, /Table/104/{1/62-2} true 14} {6 /Table/104/1/{37-43}, /Table/104/1/4{4-6}, /Table/104/1/{48-50}, /Table/104/1/5{5-8}, /Table/104/1/6{1-2} true 14} {5 /Table/104/1/1{1-2}, /Table/104/1/1{4-5}, /Table/104/1/1{8-9}, /Table/104/1/2{0-1}, /Table/104/1/2{3-6}, /Table/104/1/2{7-8}, /Table/104/1/3{1-2}, /Table/104/1/3{4-6} true 11}]
    changefeed_dist_test.go:458: range counts: [14 14 0 11 11 14 0 0]
    changefeed_dist_test.go:518: 
        	Error Trace:	github.com/cockroachdb/cockroach/pkg/ccl/changefeedccl/changefeed_dist_test.go:518
        	Error:      	"14" is not less than or equal to "12"
        	Test:       	TestChangefeedWithSimpleDistributionStrategy
        	Messages:   	counts [14 14 0 11 11 14 0 0] contains value greater than upper bound 12
    panic.go:626: -- test log scope end --
test logs left over in: outputs.zip/logTestChangefeedWithSimpleDistributionStrategy1311953055
--- FAIL: TestChangefeedWithSimpleDistributionStrategy (73.37s)

Parameters:

  • attempt=1
  • run=9
  • shard=1
Help

See also: How To Investigate a Go Test Failure (internal)

/cc @cockroachdb/cdc

This test on roachdash | Improve this report!

Jira issue: CRDB-36917
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-cdc labels Mar 22, 2024
@cockroach-teamcity cockroach-teamcity added this to the 24.1 milestone Mar 22, 2024
@blathers-crl blathers-crl bot added the A-cdc Change Data Capture label Mar 22, 2024
@rickystewart rickystewart mentioned this issue Mar 22, 2024
Merged
@rickystewart
Copy link
Collaborator

This test is generally flaky. You can see similar failures historically, for example this one

@andyyang890 andyyang890 self-assigned this Mar 22, 2024
@andyyang890 andyyang890 removed the release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. label Mar 22, 2024
@andyyang890
Copy link
Collaborator

We suspect it's because of #120077, I'll put up a PR with a fix.

@wenyihu6
Copy link
Contributor

This is probably also related to this test failure - #120470.

@andyyang890 andyyang890 mentioned this issue Mar 22, 2024
Merged
craig bot pushed a commit that referenced this issue Mar 22, 2024
@andrew-delph @rickystewart
Merge #119263 #120893
c2d249f 
119263: sql: Allow Alter Column Drop Identity Command r=annrpom a=andrew-delph

Informs: #110010

This change adds a new command, 'ALTER TABLE
ALTER [COLUMN] DROP IDENTITY [ IF EXISTS ]',
which allows an ID column to drop the related
its Identity constraint and related sequence.
'IF EXISTS' is optional and will provide a notice
if the column is not an identity.

Release note (sql change): Identity Columns can
drop the Identity constraint by running 'ALTER
TABLE t ALTER COLUMN c DROP IDENTITY [ IF EXISTS ]'.

120893: changefeedccl: skip `TestChangefeedWithSimpleDistributionStrategy` r=andyyang890 a=rickystewart

This test is flaky.

See #120870

Epic: none
Release note: None

Co-authored-by: Andrew Delph <andrewdelph@live.ca>
Co-authored-by: Ricky Stewart <ricky@cockroachlabs.com>
@craig craig bot closed this as completed in 5a5a248 Mar 22, 2024
@rharding6373 rharding6373 added A-testing Testing tools and infrastructure C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. labels Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andyyang890 andyyang890

Labels
A-cdc Change Data Capture A-testing Testing tools and infrastructure branch-master Failures and bugs on the master branch. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. T-cdc
Projects
None yet
Milestone
24.1
Development

Successfully merging a pull request may close this issue.

changefeedccl: deflake TestChangefeedWithSimpleDistributionStrategy andyyang890/cockroach
5 participants
@rickystewart @rharding6373 @cockroach-teamcity @andyyang890 @wenyihu6