-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logictest: failure in distsql_stats for virtual columns #121424
Labels
branch-master
Failures on the master branch.
branch-release-24.1
Used to mark GA and release blockers and technical advisories for 24.1
C-test-failure
Broken test (automatically or manually discovered).
O-robot
Originated from a bot.
P-2
Issues/test failures with a fix SLA of 3 months
T-sql-queries
SQL Queries Team
Milestone
Comments
michae2
added a commit
to michae2/cockroach
that referenced
this issue
Apr 2, 2024
This failure happens when we plan the query without stats. Add a SHOW HISTOGRAM to make sure we've got the right stats ready to go. Informs: cockroachdb#121424 Release note: None
This was referenced Apr 2, 2024
This was referenced Apr 18, 2024
I'm going to drop GA-blocker label since this is a test flake. |
This was referenced May 28, 2024
This was referenced May 31, 2024
@michae2 this has been failing somewhat frequently, so it'd be nice to fix this sooner than later. |
craig bot
pushed a commit
that referenced
this issue
Jun 5, 2024
125150: sql: deflake distsql_stats logic test r=yuzefovich a=michae2 I stressed this for a while and was not able to reproduce it. However, I have a theory: the failing statement is racing the rangefeed that invalidates the stats cache, and occasionally starts planning before the rangefeed causes the stale entry to be evicted from the cache. (SHOW STATISTICS does not go through the stats cache, which is why we can hit this even after that statement succeeds.) A retry on the first non-SHOW-STATISTICS statement after ANALYZE should work. (This is also what we did in #81560.) Fixes: #121424 Release note: None 125156: acceptance: preserve logs for TestDockerCLI tests in remote execution r=rickystewart a=rafiss The cleanup logic in (*cluster.DockerCluster).Cleanup takes care to preserve the logs directory if requested. Under remote execution, we need to make sure to use a temporary directory that will be captured by the remote executor. fixes #125096 Release note: None Co-authored-by: Michael Erickson <michae2@cockroachlabs.com> Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com>
blathers-crl bot
pushed a commit
that referenced
this issue
Jun 5, 2024
I stressed this for a while and was not able to reproduce it. However, I have a theory: the failing statement is racing the rangefeed that invalidates the stats cache, and occasionally starts planning before the rangefeed causes the stale entry to be evicted from the cache. (SHOW STATISTICS does not go through the stats cache, which is why we can hit this even after that statement succeeds.) A retry on the first non-SHOW-STATISTICS statement after ANALYZE should work. (This is also what we did in #81560.) Fixes: #121424 Release note: None
Dhruv-Sachdev1313
pushed a commit
to Dhruv-Sachdev1313/cockroach
that referenced
this issue
Jun 7, 2024
I stressed this for a while and was not able to reproduce it. However, I have a theory: the failing statement is racing the rangefeed that invalidates the stats cache, and occasionally starts planning before the rangefeed causes the stale entry to be evicted from the cache. (SHOW STATISTICS does not go through the stats cache, which is why we can hit this even after that statement succeeds.) A retry on the first non-SHOW-STATISTICS statement after ANALYZE should work. (This is also what we did in cockroachdb#81560.) Fixes: cockroachdb#121424 Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
branch-master
Failures on the master branch.
branch-release-24.1
Used to mark GA and release blockers and technical advisories for 24.1
C-test-failure
Broken test (automatically or manually discovered).
O-robot
Originated from a bot.
P-2
Issues/test failures with a fix SLA of 3 months
T-sql-queries
SQL Queries Team
pkg/sql/logictest/tests/5node/5node_test.TestLogic_distsql_stats failed on release-24.1 @ 5d952f80b3e1efe2e9aaed73f1fd68433880fcb7:
Parameters:
attempt=1
run=7
shard=11
Help
See also: How To Investigate a Go Test Failure (internal)
This test on roachdash | Improve this report!
Jira issue: CRDB-37243
The text was updated successfully, but these errors were encountered: