logictest: debug distsql_stats failure involving virtual columns #121584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This failure happens when we plan the query without stats. Add a SHOW HISTOGRAM to make sure we've got the right stats ready to go. Informs: cockroachdb#121424 Release note: None
|
This change is |
yuzefovich
reviewed
Apr 2, 2024
| virt {o} 1000 33 true | ||
|
|
||
| let $hist_o | ||
| SELECT histogram_id FROM [SHOW STATISTICS FOR TABLE mno] |
There was a problem hiding this comment.
I'm somewhat sceptical that this addition will help in understanding the failure. What are the reasons for "missing stats" during the planning? We already checked in the query above that there are some stats on columns m, n, and o, so the stats do get collected and written down into the system table, and we're just not using them during planning for some reason. If the histogram for o got busted, then I'd have expected that we'd still use stats on n.
nit: also EXPLAIN plans should be in execbuilder tests.
There was a problem hiding this comment.
Good points. I'll close this.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This failure happens when we plan the query without stats. Add a SHOW HISTOGRAM to make sure we've got the right stats ready to go.
Informs: #121424
Release note: None