Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: use real privileges instead of READ|WRITE #2005

Closed
mberhault opened this issue Aug 6, 2015 · 0 comments · Fixed by #2133
Closed

sql: use real privileges instead of READ|WRITE #2005

mberhault opened this issue Aug 6, 2015 · 0 comments · Fixed by #2133
Assignees
@mberhault
Milestone
Beta

Comments

@mberhault
Copy link
Contributor

We need real sql privileges rather than the fairly dumb READ|WRITE ones.

This will most likely be a mix of postgres and mysql, along with oddities on our side (eg: #2004)
@mberhault mberhault self-assigned this Aug 6, 2015
@mberhault mberhault mentioned this issue Aug 6, 2015
Closed
@mberhault mberhault mentioned this issue Aug 12, 2015
Merged
mberhault pushed a commit that referenced this issue Aug 12, 2015
Rework privilege storage.
3faa95f 
Work towards #2005.

Credentials are now stored as a sorted list of {user, privilegeBitField}
The ALL logic makes grant/revoke a bit twisted, but is probably the most
expected behavior.

GRANT, REVOKE, and SHOW GRANTS are finalized.

The final step will be to fix all the CheckPrivilege calls to use the proper
privilege and finally remove READ,WRITE.
mberhault pushed a commit that referenced this issue Aug 13, 2015
Rework privilege storage.
c0f2940 
Work towards #2005.

Credentials are now stored as a sorted list of {user, privilegeBitField}
The ALL logic makes grant/revoke a bit twisted, but is probably the most
expected behavior.

GRANT, REVOKE, and SHOW GRANTS are finalized.

The final step will be to fix all the CheckPrivilege calls to use the proper
privilege and finally remove READ,WRITE.
@petermattis petermattis added this to the v0.1 (Beta) milestone Aug 14, 2015
mberhault pushed a commit that referenced this issue Aug 14, 2015
Rework privilege storage.
baebc53 
Work towards #2005.

Credentials are now stored as a sorted list of {user, privilegeBitField}
The ALL logic makes grant/revoke a bit twisted, but is probably the most
expected behavior.

GRANT, REVOKE, and SHOW GRANTS are finalized.

The final step will be to fix all the CheckPrivilege calls to use the proper
privilege and finally remove READ,WRITE.
@tbg tbg added the SQL label Aug 15, 2015
@mberhault mberhault mentioned this issue Aug 17, 2015
Merged
@jess-edwards jess-edwards mentioned this issue Aug 17, 2015
Closed
78 tasks
mberhault pushed a commit that referenced this issue Aug 17, 2015
Use real SQL privileges.
bbd39a5 
Fixes #2005

This is just plugging in real privileges and fixing the tests.
I'm going to go clean up the sql logic tests a bit as well.
@mberhault mberhault mentioned this issue Aug 17, 2015
Merged
@tbg tbg added the PTAL label Aug 17, 2015
@tbg tbg removed the PTAL label Aug 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mberhault mberhault

Labels
None yet
Projects
None yet
Milestone
Beta
Development

Successfully merging a pull request may close this issue.

Use real SQL privileges. cockroachdb/cockroach
3 participants
@tbg @mberhault @petermattis