Use real SQL privileges. #2133
Merged
Use real SQL privileges. #2133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2005 This is just plugging in real privileges and fixing the tests. I'm going to go clean up the sql logic tests a bit as well.
|
This follows the RFC except for This means that The RFC will be replaced by proper documentation which should be kept up-to-date with the implementation. |
|
@petermattis I said I was going to enforce system privileges in this one, but it modifies a bunch more stuff, so I'm doing it in a separate PR (coming soon). |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2005
This is just plugging in real privileges and fixing the tests.
I'm going to go clean up the sql logic tests a bit as well.