Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable auto-gc for one-shot transactions #2717

Closed
bdarnell opened this issue Sep 29, 2015 · 2 comments · Fixed by #3094
Closed

Re-enable auto-gc for one-shot transactions #2717

bdarnell opened this issue Sep 29, 2015 · 2 comments · Fixed by #3094
Assignees

Comments

@bdarnell
Copy link
Contributor

We should re-enable auto-gc when possible.

From comment in ec16f29:

disable txn auto gc
this could lead to spurious test failures:

  • txn writes some intents, but not in a single
    round-trip
  • concurrent reader runs into open intent, tries to push
  • before it gets there, txn finishes with only local intents;
    txn record gets deleted
  • push begins, does not find txn entry and fails
  • potentially repeat forever or (if a push succeeds) until
    recreated txn entry times out.

I ran into this since it created an endless loop in
conjunction with buggy test code, but it's better to
disable this for now until we actually have the GC
story in place. My intuition is that we'll want to
limit this to single-roundtrip txns, whose intents
are never visible to anyone except the requests in
the batch (and even then we must be careful that
they are not collected as "skipped intents" in
some cases).

@jess-edwards jess-edwards mentioned this issue Sep 29, 2015
78 tasks
@tbg tbg mentioned this issue Sep 30, 2015
@tbg
Copy link
Member

tbg commented Sep 30, 2015

suggest to re-enable this as described in #2716 when that issue closes.

@tbg
Copy link
Member

tbg commented Oct 14, 2015

blocked on #2799, but then this should be ok.

tbg added a commit to tbg/cockroach that referenced this issue Nov 10, 2015
@tbg tbg closed this as completed in #3094 Nov 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants