-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql: UPDATE should support RETURNING non-updated columns #4368
Labels
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Milestone
Comments
petermattis
added
the
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
label
Feb 14, 2016
RaduBerinde
added a commit
to RaduBerinde/cockroach
that referenced
this issue
Feb 25, 2016
This change adds support for `RETURNING *` in inserts and deletes. For updates we currently only expand the updated columns; this is related to an existing problem (we can't return other columns even explicitly, cockroachdb#4368). Fixes cockroachdb#4593.
Related:
This returns only column
|
RaduBerinde
added a commit
to RaduBerinde/cockroach
that referenced
this issue
Feb 25, 2016
This change adds support for `RETURNING *` in inserts and deletes. For updates we currently only expand the updated columns; this is related to an existing problem (we can't return other columns even explicitly, cockroachdb#4368). Fixes cockroachdb#4593.
I wonder if we should just use all visible table columns in Edit: never mind, it's not that simple, the |
RaduBerinde
added a commit
to RaduBerinde/cockroach
that referenced
this issue
Feb 25, 2016
This change adds support for `RETURNING *` in inserts and deletes. For updates we currently only expand the updated columns; this is related to an existing problem (we can't return other columns even explicitly, cockroachdb#4368). Fixes cockroachdb#4593.
RaduBerinde
added a commit
to RaduBerinde/cockroach
that referenced
this issue
Mar 10, 2016
The RETURNING clause can only access columns that are being updated or inserted. This is fixed by always providing all columns to ReturningHelper. For update we already have values for all columns in rowVals; for insert we fill in the provided values and let the other values be NULL. Fixes cockroachdb#4368.
RaduBerinde
added a commit
to RaduBerinde/cockroach
that referenced
this issue
Mar 10, 2016
The RETURNING clause can only access columns that are being updated or inserted. This is fixed by always providing all columns to ReturningHelper. For update we already have values for all columns in rowVals; for insert we fill in the provided values and let the other values be NULL. Fixes cockroachdb#4368.
RaduBerinde
added a commit
to RaduBerinde/cockroach
that referenced
this issue
Mar 10, 2016
The RETURNING clause can only access columns that are being updated or inserted. This is fixed by always providing all columns to ReturningHelper. For update we already have values for all columns in rowVals; for insert we fill in the provided values and let the other values be NULL. Fixes cockroachdb#4368.
RaduBerinde
added a commit
to RaduBerinde/cockroach
that referenced
this issue
Mar 10, 2016
The RETURNING clause can only access columns that are being updated or inserted. This is fixed by always providing all columns to ReturningHelper. For update we already have values for all columns in rowVals; for insert we fill in the provided values and let the other values be NULL. Fixes cockroachdb#4368.
RaduBerinde
added a commit
to RaduBerinde/cockroach
that referenced
this issue
Mar 10, 2016
The RETURNING clause can only access columns that are being updated or inserted. This is fixed by always providing all columns to ReturningHelper. For update we already have values for all columns in rowVals; for insert we fill in the provided values and let the other values be NULL. Fixes cockroachdb#4368.
RaduBerinde
added a commit
to RaduBerinde/cockroach
that referenced
this issue
Mar 10, 2016
The RETURNING clause can only access columns that are being updated or inserted. This is fixed by always providing all columns to ReturningHelper. For update we already have values for all columns in rowVals; for insert we fill in the provided values and let the other values be NULL. Fixes cockroachdb#4368.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-bug
Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
The text was updated successfully, but these errors were encountered: