heapprofiler: an error about parsing a file name

[yuzefovich]

I noticed that I have this

W200924 03:22:19.585603 403 server/heapprofiler/profilestore.go:168 ⋮ [n1] ‹memstats.2020-09-23T22_59_51.191246336.txt›: ‹strconv.ParseUint: parsing "txt": invalid syntax›

in my logs.

Here is the relevant contents of the offending directory:

-rw-r-----   1 yuzefovich  staff    9718 Sep 23 15:47 memstats.2020-09-23T22_47_04.431.4399403008.txt
-rw-r-----   1 yuzefovich  staff    9743 Sep 23 15:47 memstats.2020-09-23T22_47_14.428.4400369664.txt
-rw-r-----   1 yuzefovich  staff    9767 Sep 23 15:47 memstats.2020-09-23T22_47_24.454.4401340416.txt
-rw-r-----   1 yuzefovich  staff    9768 Sep 23 15:47 memstats.2020-09-23T22_47_35.245.4402278400.txt
-rw-r-----   1 yuzefovich  staff    9789 Sep 23 15:47 memstats.2020-09-23T22_47_44.442.4403232768.txt
-rw-r-----   1 yuzefovich  staff   10402 Sep 23 15:59 memstats.2020-09-23T22_59_51.191246336.txt
-rw-r-----   1 yuzefovich  staff   10581 Sep 23 20:23 memstats.2020-09-24T03_23_49.596.4298784768.txt
-rw-r-----   1 yuzefovich  staff   10583 Sep 23 20:23 memstats.2020-09-24T03_23_59.6.4299747328.txt
-rw-r-----   1 yuzefovich  staff   10607 Sep 23 20:24 memstats.2020-09-24T03_24_09.607.4300742656.txt
-rw-r-----   1 yuzefovich  staff   10630 Sep 23 20:24 memstats.2020-09-24T03_24_19.599.4301668352.txt
-rw-r-----   1 yuzefovich  staff   10630 Sep 23 20:24 memstats.2020-09-24T03_24_29.608.4302569472.txt

I didn't modify any of the filenames myself, and I also remember seeing the same warning a week or so ago, so we might need to make the parser more flexible. I don't know how I got a file with such name though.

[irfansharif]

Seeing this as well. Lazy repro (from something unrelated I was working on adding extra stores; I'm sure we don't need the last two steps here):

roachprod destroy local; roachprod wipe local;
roachprod create local --nodes 3;
roachprod put local cockroach;
roachprod start local;
roachprod stop local:1;
roachprod start local:1 --args="--store=path=${HOME}/local/1/data --store=path=${HOME}/local/1/data2"

I was running a688bb7e4e0c1d996131bd9b586eab79cb72973f.

[knz]

thanks