release-20.2: cli,server: fix the profile file name generation #55366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
knz
force-pushed
the
backport20.2-55364
branch
from
2b94ced
to
ef5ba67
Compare
|
woah no I made it worse. Need to tweak this. |
Prior to this patch, the timestamp part in the profile filenames was using go format `.999` for the millisecond part. However, `.999` causes the millisecond part to be omitted entirely if they happen to be zero. The correct format was in fact `.000`. Release note (bug fix): The file names for generated goroutine, CPU and memory profiles were sometimes incorrect, resulting in repeated warnings like `strconv.ParseUint: parsing "txt": invalid syntax` in log files. This has been corrected.
The previous code was generating timestamps with format `.999` which caused trailing zeroes to be truncated. Since filenames with this format may still be present in data directories, this patch makes the code tolerate them. Release note: None
knz
force-pushed
the
backport20.2-55364
branch
from
ef5ba67
to
11d3e2b
Compare
|
ready for review now |
irfansharif
approved these changes
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #55364.
Backport 1/1 commits from #55630
/cc @cockroachdb/release