cli,server: fix the profile file name generation #55364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
tbg
approved these changes
Oct 9, 2020
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @yuzefovich)
|
thx bors r=tbg |
|
Build failed: |
Prior to this patch, the timestamp part in the profile filenames was using go format `.999` for the millisecond part. However, `.999` causes the millisecond part to be omitted entirely if they happen to be zero. The correct format was in fact `.000`. Release note (bug fix): The file names for generated goroutine, CPU and memory profiles were sometimes incorrect, resulting in repeated warnings like `strconv.ParseUint: parsing "txt": invalid syntax` in log files. This has been corrected.
|
typo bors r=tbg |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #54723
Prior to this patch, the timestamp part in the profile filenames was
using go format
.999for the millisecond part. However,.999causes the millisecond part to be omitted entirely if they happen to
be zero. The correct format was in fact
.000.Release note (bug fix): The file names for generated goroutine, CPU
and memory profiles were sometimes incorrect, resulting in repeated
warnings like
strconv.ParseUint: parsing "txt": invalid syntaxinlog files. This has been corrected.