Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: populate pg_rewrite table #57417

Closed
rafiss opened this issue Dec 2, 2020 · 0 comments · Fixed by #65495
Closed

sql: populate pg_rewrite table #57417

rafiss opened this issue Dec 2, 2020 · 0 comments · Fixed by #65495
Labels
A-sql-pgcatalog A-sql-pgcompat Semantic compatibility with PostgreSQL C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
SQL Sessions - Deprecated

Comments

@rafiss
Copy link
Collaborator

rafiss commented Dec 2, 2020 •
edited by exalate-issue-sync bot
Loading

Postgres tracks views in pg_rewrite: https://www.postgresql.org/docs/current/catalog-pg-rewrite.html

Even if we can't fill in all the columns, perhaps we can do the simpler ones that are just OIDs.
@rafiss rafiss added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-sql-pgcompat Semantic compatibility with PostgreSQL A-sql-pgcatalog labels Dec 2, 2020
@rafiss rafiss added this to Triage in SQL Sessions - Deprecated via automation Dec 2, 2020
@rafiss rafiss moved this from Triage to PG compat candidates in SQL Sessions - Deprecated Dec 2, 2020
@rafiss rafiss mentioned this issue Dec 2, 2020
Merged
@rafiss rafiss added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label May 12, 2021
@mnovelodou mnovelodou self-assigned this May 19, 2021
mnovelodou pushed a commit to mnovelodou/cockroach that referenced this issue May 20, 2021
sql: pg_rewrite implemented for table-view dependencies
f5d53db 
Previously, pg_depend referenced directly to pg_class for table-view
dependencies
This was inadequate because in postgres pg_depend reference to
pg_rewrite and pg_rewrite have a reference to pg_class
To address this, this patch implements pg_rewrite for table-view
dependencies and fix the reference over pg_depend

Release note (sql change): pg_rewrite implemented for table-view
dependencies

Fixes cockroachdb#57417
@mnovelodou mnovelodou mentioned this issue May 20, 2021
Merged
mnovelodou pushed a commit that referenced this issue Jun 8, 2021
sql: pg_rewrite implemented for table-view dependencies
17bef78 
Previously, pg_depend referenced directly to pg_class for table-view
dependencies
This was inadequate because in postgres pg_depend reference to
pg_rewrite and pg_rewrite have a reference to pg_class
To address this, this patch implements pg_rewrite for table-view
dependencies and fix the reference over pg_depend

Release note (sql change): pg_rewrite implemented for table-view
dependencies, Table-view dependencies are no longer stored directly
in pg_depend

Fixes #57417
craig bot pushed a commit that referenced this issue Jun 9, 2021
Merge #65495
a625dfb 
65495: sql: pg_rewrite implemented for table-view dependencies r=rafiss a=mnovelodou

Previously, pg_depend referenced directly to pg_class for table-view
dependencies
This was inadequate because in postgres pg_depend reference to
pg_rewrite and pg_rewrite have a reference to pg_class
To address this, this patch implements pg_rewrite for table-view
dependencies and fix the reference over pg_depend

Release note (sql change): pg_rewrite implemented for table-view
dependencies, Table-view dependencies are no longer stored directly
in pg_depend

Fixes #57417

Co-authored-by: MiguelNovelo <miguel.novelo@digitalonus.com>
@craig craig bot closed this as completed in 4fa76c8 Jun 9, 2021
SQL Sessions - Deprecated automation moved this from PG compat candidates to Done Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-sql-pgcatalog A-sql-pgcompat Semantic compatibility with PostgreSQL C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
No open projects
SQL Sessions - Deprecated
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: pg_rewrite implemented for table-view dependencies mnovelodou/cockroach
2 participants
@rafiss @mnovelodou