Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: prohibit PARTITION [ALL] BY for multiregion tables #59719

Closed
otan opened this issue Feb 2, 2021 · 2 comments · Fixed by #61451
Closed

sql: prohibit PARTITION [ALL] BY for multiregion tables #59719

otan opened this issue Feb 2, 2021 · 2 comments · Fixed by #61451
Assignees
@otan
Labels
A-multiregion Related to multi-region C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)

Comments

@otan
Copy link
Contributor

otan commented Feb 2, 2021 •
edited
Loading

A lot of code at the moment assumes vanilla PARTITION BY statements. If the user defines their own PARTITION BY on these tables, what should we do? Block them? Allow them but promise nothing when altering between locality configs?
@otan otan added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-multiregion Related to multi-region labels Feb 2, 2021
@otan otan changed the title sql: decide whether we allow PARTITION [ALL] BY for non-REGIONAL BY ROW tables sql: decide whether we allow PARTITION [ALL] BY for multiregion tables Feb 3, 2021
@otan otan self-assigned this Feb 26, 2021
@otan otan mentioned this issue Mar 4, 2021
Merged
otan added a commit to otan-cockroach/cockroach that referenced this issue Mar 4, 2021
@otan
sql: remove comment on cockroachdb#59719
0b21209 
Release justification: non-production code change

Release note: None
@ajstorm
Copy link
Collaborator

ajstorm commented Mar 4, 2021

Is this issue also meant to block moving to multi-region tables if there are zone configs present (at the database or table level)? If not, is there another issue for that?

@otan
Copy link
Contributor Author

otan commented Mar 4, 2021

yeah this is the blanket issue

@otan otan changed the title sql: decide whether we allow PARTITION [ALL] BY for multiregion tables sql: prohibit PARTITION [ALL] BY for multiregion tables Mar 4, 2021
@otan otan mentioned this issue Mar 4, 2021
Merged
craig bot pushed a commit that referenced this issue Mar 5, 2021
@otan
Merge #61515 #61523 #61528
b703e66 
61515: sql: prevent tables with PARTITION BY clauses from becoming multi-region r=ajstorm a=otan

Release justification: low-risk update to new functionality
Release note: None

Refs #59719

61523: geo/geomfn: implement ST_Snap r=otan a=alsohas

This patch implements ST_Snap.

Resolves #49040

Release justification: low risk, high benefit changes to existing functionality
Release note (sql change): ST_Snap is now available.

61528: roachtest: bump activerecord adapter tests to 6.1.0beta2 r=rafiss a=otan

Release justification: non-production code change

Release note: None

Co-authored-by: Oliver Tan <otan@cockroachlabs.com>
Co-authored-by: Abdullah Islam <abdullah_islam@uri.edu>
otan added a commit to otan-cockroach/cockroach that referenced this issue Mar 5, 2021
@otan
sql: remove comment on cockroachdb#59719
a6fd9d8 
Release justification: non-production code change

Release note: None
@craig craig bot closed this as completed in f02e38f Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@otan otan

Labels
A-multiregion Related to multi-region C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: block PARTITION BY on multi-region tables otan-cockroach/cockroach
2 participants
@otan @ajstorm