Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: TestSetupIdleMonitor_WithWarmupProvided failed #66767

Closed
cockroach-teamcity opened this issue Jun 23, 2021 · 2 comments · Fixed by #68431
Closed

server: TestSetupIdleMonitor_WithWarmupProvided failed #66767

cockroach-teamcity opened this issue Jun 23, 2021 · 2 comments · Fixed by #68431
Assignees
@darinpp
Labels
A-cc-enablement Pertains to current CC production issues or short-term projects branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.

Comments

@cockroach-teamcity
Copy link
Member

server.TestSetupIdleMonitor_WithWarmupProvided failed with artifacts on master @ 52a66f85ffd5849719b5add2cace05966c169a50:

=== RUN   TestSetupIdleMonitor_WithWarmupProvided
    test_log_scope.go:73: test logs captured to: /go/src/github.com/cockroachdb/cockroach/artifacts/logTestSetupIdleMonitor_WithWarmupProvided543431415
    test_log_scope.go:74: use -show-logs to present logs inline
    testserver_test.go:133: stop on idle didn't trigger
    testserver_test.go:135: -- test log scope end --
--- FAIL: TestSetupIdleMonitor_WithWarmupProvided (0.57s)
Reproduce

To reproduce, try: 

make stressrace TESTS=TestSetupIdleMonitor_WithWarmupProvided PKG=./pkg/server TESTTIMEOUT=5m STRESSFLAGS='-timeout 5m' 2>&1

Parameters in this failure:

  • GOFLAGS=-json

/cc @cockroachdb/server @cockroachdb/test-eng darinpp

This test on roachdash | Improve this report!
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels Jun 23, 2021
@cockroach-teamcity
Copy link
Member Author

server.TestSetupIdleMonitor_WithWarmupProvided failed with artifacts on master @ fc52301ef18d30f9e56179e977908a8427fda274:

=== RUN   TestSetupIdleMonitor_WithWarmupProvided
    test_log_scope.go:73: test logs captured to: /go/src/github.com/cockroachdb/cockroach/artifacts/logTestSetupIdleMonitor_WithWarmupProvided286468958
    test_log_scope.go:74: use -show-logs to present logs inline
    testserver_test.go:117: 
        	Error Trace:	testserver_test.go:117
        	Error:      	Should be false
        	Test:       	TestSetupIdleMonitor_WithWarmupProvided
    panic.go:613: -- test log scope end --
--- FAIL: TestSetupIdleMonitor_WithWarmupProvided (0.34s)
Reproduce

To reproduce, try: 

make stressrace TESTS=TestSetupIdleMonitor_WithWarmupProvided PKG=./pkg/server TESTTIMEOUT=5m STRESSFLAGS='-timeout 5m' 2>&1

Parameters in this failure:

  • GOFLAGS=-json

/cc @cockroachdb/server @cockroachdb/test-eng darinpp

This test on roachdash | Improve this report!

@otan
Copy link
Contributor

otan commented Jun 29, 2021

cc @darinpp this test flakes regularly in my PRs. can this test not rely on time.Sleep?

otan added a commit to otan-cockroach/cockroach that referenced this issue Jun 29, 2021
@otan
server: skip TestSetupIdleMonitor_WithWarmupProvided
8bf01c0 
Refs: cockroachdb#66767

Reason: flaky test

Generated by bin/skip-test.

Release justification: non-production code changes

Release note: None
@otan otan mentioned this issue Jun 29, 2021
Merged
craig bot pushed a commit that referenced this issue Jun 29, 2021
@otan
Merge #66998
bb89f01 
66998: server: skip TestSetupIdleMonitor_WithWarmupProvided r=tbg a=otan

Refs: #66767

Reason: flaky test

Generated by bin/skip-test.

Release justification: non-production code changes

Release note: None

Co-authored-by: Oliver Tan <otan@cockroachlabs.com>
@knz knz added the A-cc-enablement Pertains to current CC production issues or short-term projects label Jul 29, 2021
darinpp added a commit to darinpp/cockroach that referenced this issue Aug 4, 2021
@darinpp
sql/tenant: add idle detection and exit flag
07b40de 
We previoulsy had a flag `--idle-exit-after` that was used to monitor the
active SQL connections and terminate the server if there are no more
clients. We don't need that functionality anymore so this PR removes it.
It also fixes the issues with the related flaky tests.
Fixes cockroachdb#66767
Release note: None
@darinpp darinpp mentioned this issue Aug 4, 2021
Merged
craig bot pushed a commit that referenced this issue Aug 9, 2021
@darinpp
Merge #68431
aa9701d 
68431: sql/tenant: remove idle detection and exit flag r=darinpp a=darinpp

We previoulsy had a flag `--idle-exit-after` that was used to monitor the
active SQL connections and terminate the server if there are no more
clients. We don't need that functionality anymore so this PR removes it.
It also fixes the issues with the related flaky tests.
Fixes #66767
Release note: None

Co-authored-by: Darin Peshev <darinp@gmail.com>
@craig craig bot closed this as completed in 7867b59 Aug 9, 2021
sajjadrizvi pushed a commit to sajjadrizvi/cockroach that referenced this issue Aug 10, 2021
@darinpp
sql/tenant: remove idle detection and exit flag
b1f73fa 
We previoulsy had a flag `--idle-exit-after` that was used to monitor the
active SQL connections and terminate the server if there are no more
clients. We don't need that functionality anymore so this PR removes it.
It also fixes the issues with the related flaky tests.
Fixes cockroachdb#66767
Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darinpp darinpp

Labels
A-cc-enablement Pertains to current CC production issues or short-term projects branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql/tenant: remove idle detection and exit flag darinpp/cockroach
4 participants
@knz @otan @darinpp @cockroach-teamcity