Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: DB Console URL context is lost when redirected to log in page #67329

Closed
thtruo opened this issue Jul 7, 2021 · 1 comment · Fixed by #67857
Closed

ui: DB Console URL context is lost when redirected to log in page #67329

thtruo opened this issue Jul 7, 2021 · 1 comment · Fixed by #67857
Assignees
@vladlos
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
Cluster UI

Comments

@thtruo
Copy link
Contributor

thtruo commented Jul 7, 2021 •
edited by exalate-issue-sync bot

Context
URL context is lost in redirection with DB Console. A link to the UI will direct you to the correct page as expected, ONLY if you are already logged in. If you are not, it redirects to the login page and the context in the URL is lost.

Example: URL https://admin-flying-bison-868.gcp-us-east4.cockroachlabs.cloud:8080/#/metrics/sql/cluster?start=1625691660&end=1625691870

Desired behavior
Ideally, if a non-logged-in user who attempts to access a particular page in DB Console gets redirected to the login page, they should be directed to the particular page after successfully logging in.

Epic CRDB-8313
@thtruo thtruo added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-cluster-ui labels Jul 7, 2021
@thtruo thtruo added this to Backlog in Cluster UI via automation Jul 7, 2021
@thtruo
Copy link
Contributor Author

thtruo commented Jul 7, 2021

Assigning to @nkodali for triage

@exalate-issue-sync exalate-issue-sync bot assigned vladlos and unassigned nkodali Jul 16, 2021
@vladlos vladlos mentioned this issue Jul 21, 2021
Merged
vladlos added a commit to vladlos/cockroach that referenced this issue Jul 21, 2021
@vladlos
ui: fix redirect to requested page after login
5d82333 
if not logged user try to open some specific page it will be
redirected to it after login. eventually we had this in place
before, but it become not working due to bracking changes
in react router library.

Resolves: cockroachdb#67329

Release note(ui): fix redirect to originaly requested page after user login
@vladlos vladlos mentioned this issue Jul 21, 2021
Merged
vladlos added a commit to vladlos/cockroach that referenced this issue Jul 21, 2021
@vladlos
ui: fix redirect to requested page after login
63d780e 
if not logged user try to open some specific page it will be
redirected to it after login. eventually we had this in place
before, but it become not working due to bracking changes
in react router library.

Resolves: cockroachdb#67329

Release note(ui): fix redirect to originaly requested page after user login
@vladlos vladlos mentioned this issue Jul 21, 2021
Merged
craig bot pushed a commit that referenced this issue Jul 23, 2021
@vladlos
Merge #67857
42ce127 
67857: ui: fix redirect to requested page after login r=elkmaster a=elkmaster

if not logged user try to open some specific page it will be
redirected to it after login. eventually we had this in place
before, but it become not working due to bracking changes
in react router library.

Resolves: #67329

Release note(ui): fix redirect to originaly requested page after user login

Co-authored-by: Vlad Los <carrott9@gmail.com>
@craig craig bot closed this as completed in 3852a0d Jul 23, 2021
Cluster UI automation moved this from Backlog to Milestone: Done Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vladlos vladlos

Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
Projects
No open projects
Cluster UI
  
Milestone: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ui: fix redirect to requested page after login vladlos/cockroach
3 participants
@nkodali @thtruo @vladlos