bazel: should add a lint check to make sure cockroach doesn't import testing or go/build
#81526
Labels
A-build-system
C-enhancement
Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
P-3
Issues/test failures with no fix SLA
T-dev-inf
Comments
rickystewart
added
C-enhancement
rickystewart
added a commit
to rickystewart/cockroach
that referenced
this issue
Apr 7, 2023
This test does not work: 1. The test [has been broken](cockroachdb#74119) for years. 2. The test is not sensible in the Bazel world anyway, and under remote execution the test fails with an error like the following: ``` build.go:59: go/build: go list github.com/cockroachdb/cockroach/pkg/cmd/cockroach: fork/exec GOROOT/bin/go: no such file or directory ``` The bug to replace this test with working functionality based on Bazel is cockroachdb#81526. Epic: CRDB-17165 Release note: None Closes cockroachdb#74119.
craig bot
pushed a commit
that referenced
this issue
Apr 10, 2023
100813: streamingccl: deflake TestRandomClientGeneration r=adityamaru a=msbutler This patch fixes 4 bugs in TestRandomClientGeneration that were responsible for the persistent flakiness and lack of coverage in this test: - the randomeStreamClient no longer instantiates keys with a table prefix that collides with the job info table prefix. This collision was the original cause of the flakes reported in #99343. - getPartitionSpanToTableId() now generates a correct map from source partition key space to table Id. Previously, the key spans in the map didn't contain keys that mapped to anything logical in the cockroach key space. - assertKVs() now checks for keys in the destination tenant keyspace. - assertKVs() now actually asserts that kvs were found. Before, the assertion could pass if no keys were actually checked, which has been happening for months and allowed the bugs above to infest this test. Fixes #99343 Release note: None 100952: cli: trash `TestNoLinkForbidden` r=rail a=rickystewart This test does not work: 1. The test [has been broken](#74119) for years. 2. The test is not sensible in the Bazel world anyway, and under remote execution the test fails with an error like the following: ``` build.go:59: go/build: go list github.com/cockroachdb/cockroach/pkg/cmd/cockroach: fork/exec GOROOT/bin/go: no such file or directory ``` The bug to replace this test with working functionality based on Bazel is #81526. Epic: CRDB-17165 Release note: None Closes #74119. 100965: sql: link issue to unimplemented mutations in udfs r=mgartner,rytaft a=rharding6373 Links an issue to the unimplemented errors for mutations in UDFs. Epic: None Informs: #87289 Fixes: #99715 Release note: None Co-authored-by: Michael Butler <butler@cockroachlabs.com> Co-authored-by: Ricky Stewart <rickybstewart@gmail.com> Co-authored-by: rharding6373 <rharding6373@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This would replace the final remaining use of
buildutil.VerifyNoImportswhich can be found inpkg/cli/flags_test.go.Jira issue: CRDB-15102
Epic CRDB-36213
The text was updated successfully, but these errors were encountered: