Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings: tenant-ro should read host's value #82959

Closed
dt opened this issue Jun 15, 2022 · 1 comment
Closed

settings: tenant-ro should read host's value #82959

dt opened this issue Jun 15, 2022 · 1 comment
Labels
A-configurability Pertains to cluster settings, CLI flags, env vars etc A-multitenancy Related to multi-tenancy C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-shared-systems Shared Systems Team

Comments

@dt
Copy link
Member

dt commented Jun 15, 2022

Tenant ReadOnly settings should observe the host's value if they are not overridden. This is similar to a behavior described in the RFC as "SystemVisible" (#79223) where a tenant may wish to adjust some behavior depending on how the host cluster is configured but does not control that configuration, such as send batches according to its size limits or enable changefeeds if it has rangefeeds enabled, etc.

There is little benefit to the current behavior of a non-overridden setting returning just default value: we can already get that behavior from a tenant-rw setting, including preventing it from being set by simply adding an override on the host side. The ability to observe but not set the host's value is however quite distinct from the tenant-rw behavior, and would be valuable in the separate tenant-ro class.

Jira issue: CRDB-16756

@dt dt added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) A-multitenancy Related to multi-tenancy A-configurability Pertains to cluster settings, CLI flags, env vars etc labels Jun 15, 2022
@exalate-issue-sync exalate-issue-sync bot added the T-shared-systems Shared Systems Team label Jan 10, 2023
@stevendanna
Copy link
Collaborator

I'm closing this as I think we got to a place where we've solved the underlying use cases here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-configurability Pertains to cluster settings, CLI flags, env vars etc A-multitenancy Related to multi-tenancy C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-shared-systems Shared Systems Team
Projects
Development

No branches or pull requests

2 participants