Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pg_catalog.pg_relation_size() #86017

Open
Karitham opened this issue Aug 12, 2022 · 3 comments
Open

pg_catalog.pg_relation_size() #86017

Karitham opened this issue Aug 12, 2022 · 3 comments
Labels
A-sql-pgcompat Semantic compatibility with PostgreSQL C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-starter Might be suitable for a starter project for new employees or team members. O-community Originated from the community T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) X-blathers-triaged blathers was able to find an owner

Comments

@Karitham
Copy link

Karitham commented Aug 12, 2022

Is your feature request related to a problem? Please describe.
Not having pg_catalog.pg_relation_size() breaks usql's introspection queries.

Describe the solution you'd like
Adding pg_relation_size

Describe alternatives you've considered
Trying to replace usql's usage of pg_relation_size with a cockroach specific implementation for metadata and instrumentation.

Additional context
https://github.com/xo/usql/blob/master/drivers/metadata/postgres/metadata.go The ideal output would be supporting the queries built here, to support all these features.

Jira issue: CRDB-18527

@Karitham Karitham added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Aug 12, 2022
@blathers-crl
Copy link

blathers-crl bot commented Aug 12, 2022

Hello, I am Blathers. I am here to help you get the issue triaged.

I have CC'd a few people who may be able to assist you:

  • @cockroachdb/sql-experience (found keywords: pg_)

If we have not gotten back to your issue within a few business days, you can try the following:

  • Join our community slack channel and ask on #cockroachdb.
  • Try find someone from here if you know they worked closely on the area and CC them.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@blathers-crl blathers-crl bot added O-community Originated from the community X-blathers-triaged blathers was able to find an owner labels Aug 12, 2022
@rafiss
Copy link
Collaborator

rafiss commented Aug 12, 2022

Thanks for the issue! #20712 is a similar issue where we've been tracking this work.

@knz
Copy link
Contributor

knz commented May 19, 2023

After #103128 is completed, there will be a new built-in function able to compute fine grained MVCC stats per KV span. We will be able to combine this with the index_span() builtin to implement pg_relation_size and the other size built-in functions.

@maryliag maryliag added T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) and removed A-kv-observability T-cluster-observability labels Nov 3, 2023
@rafiss rafiss added the A-sql-pgcompat Semantic compatibility with PostgreSQL label Nov 7, 2023
@rafiss rafiss added the E-starter Might be suitable for a starter project for new employees or team members. label Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sql-pgcompat Semantic compatibility with PostgreSQL C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-starter Might be suitable for a starter project for new employees or team members. O-community Originated from the community T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) X-blathers-triaged blathers was able to find an owner
Projects
No open projects
Status: Triage
Development

No branches or pull requests

5 participants