-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oracle migration example script fails in python3 #86785
Comments
I think a simple fix would be to replace for rec in reader:
writer.writerow(rec.strip()) |
Thanks @ianjevans I'll test out this change tomorrow. |
@ianjevans I get the following similar, but different, suggestion from
Running your suggestion through However, we'd need an Oracle instance, or a sample |
We have marked this issue as stale because it has been inactive for |
Describe the problem
The
fix-example.py
script provided by engineering to DOCs team errors when run bypython3
, aspython2
'sstrip
method has been deprecated ever since. This report came through to DOCS from the TSE org, having been reported by a client you've heard of who tried to run this script and received an error.Please take a moment to update this script, sent to DOCS in 2019, for
python3
as you can. Thank you!To Reproduce
Follow migration process as described on doc, noting failure in step 4 when run with
python3
instead ofpython2
. Note also that doc specifies using python3. See DOC - 5461 for TSE report of error. See original v19.1 version of this page to see that original invocation specifiedpython2
. It seems somewhere along the way, DOCS updated the invocation step to python3 without testing that the script worked inpython3
. Today we have learned that it does not.Expected behavior
Modern machines running modern python are able to migrate from Oracle to CRDB successfully.
Additional context
Original python script was born in 2019, released as part of this doc alongside CRDB v19.1. I spoke with @drewdeally who provided some context on the history of this script, and advised that we update it for python3. Thanks for the assist!
Jira issue: CRDB-18933
The text was updated successfully, but these errors were encountered: