Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: opt: fix internal error when exploration uncovers null-rejection #100668

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Apr 5, 2023

Backport 1/1 commits from #100565 on behalf of @DrewKimball.

/cc @cockroachdb/release


It is possible for exploration rules to reveal opportunities to null-reject (simplify) an outer join that were not visible during normalization. Previously, this would cause an internal error, since it was assumed null-rejection would never be requested by an expression that can prove the requested column is non-null. This patch removes the assertion and instead removes any proven non-null columns from the requested null-rejection column set. Note that this solution is orthogonal to improving null-rejection during normalization - one instance of this is tracked in #100564.

Fixes #100559

Release note (bug fix): Fixed a bug existing since before 22.1 that could cause an internal error in rare cases for a query with outer joins that can be simplified to non-outer joins and at least one semi-join.


Release justification: low-risk fix for optimizer internal error

@blathers-crl blathers-crl bot requested a review from a team as a code owner April 5, 2023 00:07
@blathers-crl blathers-crl bot requested a review from msirek April 5, 2023 00:07
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-100565 branch 2 times, most recently from 79dbcaa to 2060526 Compare April 5, 2023 00:07
@blathers-crl
Copy link
Author

blathers-crl bot commented Apr 5, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Apr 5, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@msirek msirek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @DrewKimball and @mgartner)

It is possible for exploration rules to reveal opportunities to
null-reject (simplify) an outer join that were not visible during
normalization. Previously, this would cause an internal error, since
it was assumed null-rejection would never be requested by an expression
that can prove the requested column is non-null. This patch removes the
assertion and instead removes any proven non-null columns from the
requested null-rejection column set. Note that this solution is
orthogonal to improving null-rejection during normalization - one
instance of this is tracked in #100564.

Fixes #100559

Release note (bug fix): Fixed a bug existing since before 22.1 that
could cause an internal error in rare cases for a query with outer joins
that can be simplified to non-outer joins and at least one semi-join.
@DrewKimball DrewKimball force-pushed the blathers/backport-release-22.2-100565 branch from 2060526 to 902e358 Compare April 18, 2023 18:21
@DrewKimball DrewKimball merged commit 0a453cf into release-22.2 Apr 19, 2023
@DrewKimball DrewKimball deleted the blathers/backport-release-22.2-100565 branch April 19, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants