sql: allow manipulating unqualified index names.

[knz]

With this patch, one can use a simple index name "idxname" instead of
"tablename@idxname" with DROP INDEX and ALTER INDEX.

Fixes #8800.

cc @dt

---

This change is

[maddyblue]

Review status: 0 of 11 files reviewed at latest revision, 2 unresolved discussions, all commit checks successful.

---

pkg/sql/split.go, line 53 at r1 (raw file):

  }

  if n.Index != nil && n.Index.SearchTable {

Why do we need the check for n.Index != nil here?

Also this if block is repeated almost verbatim (except for this n.Index check) in three places. Can we make a method on n to correctly set tn and n.Index?

---

pkg/sql/parser/sql.y, line 4391 at r1 (raw file):

    $$.val = &TableNameWithIndex{Table: $1.normalizableTableName(), Index: Name($3)}
  }
| qualified_name

Why not name?

---

Comments from Reviewable

[knz]

Review status: 0 of 11 files reviewed at latest revision, 2 unresolved discussions, all commit checks successful.

---

pkg/sql/split.go, line 53 at r1 (raw file):

Previously, mjibson (Matt Jibson) wrote…

Why do we need the check for n.Index != nil here?

Also this if block is repeated almost verbatim (except for this n.Index check) in three places. Can we make a method on n to correctly set tn and n.Index?

The check for n.Index is because this node is used for both ALTER TABLE ... SPLIT AT and ALTER INDEX ... SPLIT AT.

But I refactored the code as suggested.

---

pkg/sql/parser/sql.y, line 4391 at r1 (raw file):

Previously, mjibson (Matt Jibson) wrote…

Why not name?

Because if I don't have a current database in the planner I still want to do e.g. "DROP INDEX mydb.myindex".

---

Comments from Reviewable

[maddyblue]

---

Review status: 0 of 11 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

---

Comments from Reviewable

[knz]

TFYR!

---

Review status: 0 of 11 files reviewed at latest revision, 2 unresolved discussions.

---

Comments from Reviewable