ttl: allow outbound foreign keys on TTL tables #101236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Removes a text column a few subtests have that is not part of the actual tests. Release note: None
The row_level_ttl logic test is now broken down into subtests to more easily isolate failures. Release note: None
Fixes #101225 This change allows TTL tables to have outbound foreign keys. Outbound foreign keys are unaffected by rows being deleted from the TTL table itself. Release note (sql change): Allow outbound foreign keys on TTL tables.
otan
reviewed
Apr 11, 2023
| desc.GetName(), | ||
| )) | ||
| } | ||
| if desc.HasRowLevelTTL() && len(desc.InboundForeignKeys()) > 0 { |
There was a problem hiding this comment.
any reason not to support all the cases if we're not doing strict filtering?
There was a problem hiding this comment.
I will handle it in a followup PR.
There is an issue with job SessionData not respecting optDrivenFKCascadesClusterLimit that I have to resolve #101265.
otan
approved these changes
Apr 12, 2023
rafiss
approved these changes
Apr 12, 2023
There was a problem hiding this comment.
nice!
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @otan)
|
bors r=otan,rafiss |
|
Build succeeded: |
This was referenced Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #101225
This change allows TTL tables to have outbound foreign keys. Outbound foreign
keys are unaffected by rows being deleted from the TTL table itself.
Release note (sql change): Allow outbound foreign keys on TTL tables.