Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.1: sqlstats: ignore SET stmts on insights #101669

Merged
merged 1 commit into from
Apr 17, 2023
Merged

release-23.1: sqlstats: ignore SET stmts on insights #101669

merged 1 commit into from
Apr 17, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Apr 17, 2023 •
edited by maryliag
Loading

Backport 1/1 commits from #101563 on behalf of @maryliag.

/cc @cockroachdb/release

Statements such as SET vectorize = _ were being listed on Insights, but there is nothing the user can do about this, since is expected to be slow on some cases.
This commit creates an ignore function, that currently only ignore statements startings with SET , but can be improved with more feedback and other statements that don't make sense to be part of our insights can be added to the list.

Fixes #98358

Release note (sql change): Statements of type SET are not longer displayed on the Insights page.

Release justification: small change, big impact

@maryliag
sqlstats: ignore SET stmts on insights
e6db005 
Statements such as `SET vectorize = _` were being listed
on Insights, but there is nothing the user can do about this,
since is expected to be slow on some cases.
This commit creates an ignore function, that currently only
ignore statements startings with `SET `, but can be improved
with more feedback and other statements that don't make sense
to be part of our insights can be added to the list.

Fixes #98358

Release note (sql change): Statements of type `SET ` are not longer
displayed on the Insights page.
@blathers-crl blathers-crl bot requested a review from a team April 17, 2023 18:54
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-101563 branch from bbd55cc to e6db005 Compare April 17, 2023 18:54
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Apr 17, 2023
@blathers-crl
Copy link
Author

blathers-crl bot commented Apr 17, 2023 •
edited by maryliag
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

j82w
j82w approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@j82w j82w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @maryliag, @xinhaoz, and @yuzefovich)

@maryliag maryliag merged commit c4e29a2 into release-23.1 Apr 17, 2023
@maryliag maryliag deleted the blathers/backport-release-23.1-101563 branch April 17, 2023 20:09
@cockroach-teamcity cockroach-teamcity mentioned this pull request Apr 18, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j82w j82w j82w approved these changes

@maryliag maryliag Awaiting requested review from maryliag

@xinhaoz xinhaoz Awaiting requested review from xinhaoz

@yuzefovich yuzefovich Awaiting requested review from yuzefovich

Assignees

@maryliag maryliag

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @j82w @maryliag