Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: sql: use lease to get qualified function name #103089

Merged
merged 1 commit into from
May 11, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented May 11, 2023

Backport 1/1 commits from #103080 on behalf of @chengxiong-ruan.

/cc @cockroachdb/release


fixes: #102043

Previously we always skip lease to get a fully qualified UDF name. Before 23.1 it was not terrible because we only use qualified names in schema changers. In 23.1 we started fetching UDF name when resolving UDFs due to some schema changer needs. This is bad because the type checking hot path share the same resolution code. This commit fixes it to use the cache instead of reading from kv. Luckily that this only impact UDFs, in memory cache is always used for builtin functions.

Release note (performance improvement): this change fixed a bug where kv was read when fetching qualified name of a leased UDF.


Release justification: bug fix for a performance regression.

fixes: #102043

Previously we always skip lease to get a fully qualified
UDF name. Before 23.1 it was not terrible because we only
use qualified names in schema changers. In 23.1 we started
fetching UDF name when resolving UDFs due to some schema
changer needs. This is bad because the type checking hot
path share the same resolution code. This commit fixes it
to use the cache instead of reading from kv. Luckily that
this only impact UDFs, in memory cache is always used for
builtin functions.

Release note (performance improvement): this change fixed
a bug where kv was read when fetching qualified name of a
leased UDF.
@blathers-crl blathers-crl bot requested a review from a team May 11, 2023 03:34
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-103080 branch 2 times, most recently from dea607f to 8fe2e83 Compare May 11, 2023 03:34
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels May 11, 2023
@blathers-crl
Copy link
Author

blathers-crl bot commented May 11, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@chengxiong-ruan chengxiong-ruan merged commit 2df72a5 into release-23.1 May 11, 2023
@chengxiong-ruan chengxiong-ruan deleted the blathers/backport-release-23.1-103080 branch May 11, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants