release-23.1: sql: use lease to get qualified function name #103089
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #103080 on behalf of @chengxiong-ruan.
/cc @cockroachdb/release
fixes: #102043
Previously we always skip lease to get a fully qualified UDF name. Before 23.1 it was not terrible because we only use qualified names in schema changers. In 23.1 we started fetching UDF name when resolving UDFs due to some schema changer needs. This is bad because the type checking hot path share the same resolution code. This commit fixes it to use the cache instead of reading from kv. Luckily that this only impact UDFs, in memory cache is always used for builtin functions.
Release note (performance improvement): this change fixed a bug where kv was read when fetching qualified name of a leased UDF.
Release justification: bug fix for a performance regression.