Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: Keep spaces when using unaccent #103819

Merged
merged 1 commit into from May 25, 2023

Conversation

aeekayy
Copy link
Contributor

@aeekayy aeekayy commented May 24, 2023

The previous behavior of unaccent removed spaces, but that is not
compatible with the PG implementation.

Fixes #100407

Release note (bug fix): The unaccent builtin function no longer removes
spaces.

Operation

SELECT unaccent('Héllô Wõrld!');

Expected behavior

Hello World!

Old behavior

HelloWorld!

@blathers-crl
Copy link

blathers-crl bot commented May 24, 2023

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

Before a member of our team reviews your PR, I have some potential action items for you:

  • Please ensure your git commit message contains a release note.
  • When CI has completed, please ensure no errors have appeared.

I was unable to automatically find a reviewer. You can try CCing one of the following members:

  • A person you worked with closely on this PR.
  • The person who created the ticket, or a CRDB organization member involved with the ticket (author, commenter, etc.).
  • Join our community slack channel and ask on #contributors.
  • Try find someone else from here.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@blathers-crl blathers-crl bot added O-community Originated from the community X-blathers-untriaged blathers was unable to find an owner labels May 24, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@jayshrivastava jayshrivastava added the T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) label May 25, 2023
@jayshrivastava jayshrivastava requested a review from a team May 25, 2023 14:05
Copy link
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your contribution! i will merge this

Copy link
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update your commit message. i tried making this change, but i don't have permission to push to your fork

builtins: update unaccent to leave spaces alone

The previous behavior of unaccent removed spaces, but that is not
compatible with the PG implementation.

Release note (bug fix): The unaccent builtin function no longer removes
spaces.

@aeekayy aeekayy requested a review from rafiss May 25, 2023 18:10
Copy link
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the commit message still needs to be updated

The previous behavior of unaccent removed spaces, but that is not
compatible with the PG implementation.

Release note (bug fix): The unaccent builtin function no longer removes
spaces.
@blathers-crl
Copy link

blathers-crl bot commented May 25, 2023

Thank you for updating your pull request.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Copy link
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

bors r+

@aeekayy
Copy link
Contributor Author

aeekayy commented May 25, 2023

@rafiss I pushed the updated commit message

@craig
Copy link
Contributor

craig bot commented May 25, 2023

Build succeeded:

@craig craig bot merged commit 70ee1b1 into cockroachdb:master May 25, 2023
4 of 7 checks passed
@aeekayy aeekayy deleted the issues/100407 branch May 25, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-community Originated from the community T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) X-blathers-untriaged blathers was unable to find an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unaccent() function strips spaces
4 participants