New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql: Keep spaces when using unaccent #103819
Conversation
Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. Before a member of our team reviews your PR, I have some potential action items for you:
I was unable to automatically find a reviewer. You can try CCing one of the following members:
🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your contribution! i will merge this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please update your commit message. i tried making this change, but i don't have permission to push to your fork
builtins: update unaccent to leave spaces alone
The previous behavior of unaccent removed spaces, but that is not
compatible with the PG implementation.
Release note (bug fix): The unaccent builtin function no longer removes
spaces.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the commit message still needs to be updated
The previous behavior of unaccent removed spaces, but that is not compatible with the PG implementation. Release note (bug fix): The unaccent builtin function no longer removes spaces.
Thank you for updating your pull request. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
bors r+
@rafiss I pushed the updated commit message |
Build succeeded: |
The previous behavior of unaccent removed spaces, but that is not
compatible with the PG implementation.
Fixes #100407
Release note (bug fix): The unaccent builtin function no longer removes
spaces.
Operation
Expected behavior
Old behavior