release-22.2: ttl: allow inbound foreign keys on TTL tables #105342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
|
This change is |
…ivenFKCascadesClusterLimit 22.2 compatibility Informs #101265 The original backport for #101265 is incomplete in 22.2 where the session data for jobs is initialized differently from 23.1+. This PR adds to the original backport by reading `optDrivenFKCascadesClusterLimit` inside `Server.newSessionData`. Release note: None
Fixes #76407 This change allows TTL tables to have inbound foreign keys. If the inbound foreign key has the ON DELETE CASCADE option, the TTL job will work as usual. If it has the ON DELETE RESTRICT option, the TTL job will fail if a row references the TTL table (see #101372). Release note (sql change): Allow inbound foreign keys on TTL tables.
rafiss
approved these changes
Jun 22, 2023
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @ecwall)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 2/2 commits from #101376.
/cc @cockroachdb/release
Fixes #76407
This change allows TTL tables to have inbound foreign keys. If the inbound foreign key has the ON DELETE CASCADE option, the TTL job will work as usual. If it has the ON DELETE RESTRICT option, the TTL job will fail if a row references the TTL table (see #101372).
Release note (sql change): Allow inbound foreign keys on TTL tables.
Release justification: Unblock customers needing inbound FKs on TTL table.