sql: add missing nil check #106904
Merged
sql: add missing nil check #106904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: cockroachdb#106658 Release note: None
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
dt
approved these changes
Jul 17, 2023
|
bors r=dt |
|
Build succeeded: |
adityamaru
added a commit
to adityamaru/cockroach
that referenced
this pull request
Jul 20, 2023
This was fixed in cockroachdb#106904 but it looks like some file movement in cockroachdb#105624 got rid of the nil check. This patch re-adds the nil check along with a test, and also some additional safeguards to not collect any execution details for non-existent jobs. Fixes: cockroachdb#106970 Release note: None
adityamaru
added a commit
to adityamaru/cockroach
that referenced
this pull request
Jul 20, 2023
This was fixed in cockroachdb#106904 but it looks like some file movement in cockroachdb#105624 got rid of the nil check. This patch re-adds the nil check along with a test, and also some additional safeguards to not collect any execution details for non-existent jobs. Fixes: cockroachdb#106970 Release note: None
craig bot
pushed a commit
that referenced
this pull request
Jul 21, 2023
107254: sql: fix panic in request_job_execution_details r=rafiss a=adityamaru This was fixed in #106904 but it looks like some file movement in #105624 got rid of the nil check. This patch re-adds the nil check along with a test, and also some additional safeguards to not collect any execution details for non-existent jobs. Fixes: #106970 Release note: None Co-authored-by: adityamaru <adityamaru@gmail.com>
THardy98
pushed a commit
to THardy98/cockroach
that referenced
this pull request
Jul 24, 2023
This was fixed in cockroachdb#106904 but it looks like some file movement in cockroachdb#105624 got rid of the nil check. This patch re-adds the nil check along with a test, and also some additional safeguards to not collect any execution details for non-existent jobs. Fixes: cockroachdb#106970 Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #106658
Release note: None