Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acceptance: deflake test_demo_node_cmds #107140

Merged

Conversation

AlexTalks
Copy link
Contributor

Previously the acceptance test test_demo_node_cmds, which attempts to shutdown and decommission some nodes using the cockroach demo CLI, would sometimes be flaky due to delays in propagating information via gossip. This change fixes these flakes by utilizing the virtual table crdb_internal.kv_node_liveness rather than the gossip-based gossip_liveness virtual table.

Fixes: #76391

Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@AlexTalks AlexTalks requested a review from knz July 19, 2023 17:18
@andrewbaptist
Copy link
Collaborator

@AlexTalks Just noticed this - any reason not to merge it?

@AlexTalks AlexTalks added backport-23.1.x Flags PRs that need to be backported to 23.1 backport-22.2.x labels Aug 8, 2023
Previously the acceptance test `test_demo_node_cmds`, which attempts to
shutdown and decommission some nodes using the `cockroach demo` CLI,
would sometimes be flaky due to delays in propagating information via
gossip. This change fixes these flakes by utilizing the virtual table
`crdb_internal.kv_node_liveness` rather than the gossip-based
`gossip_liveness` virtual table.

Fixes: cockroachdb#76391

Release note: None
@AlexTalks
Copy link
Contributor Author

@AlexTalks Just noticed this - any reason not to merge it?

Nope - will rebase and do so now!

@AlexTalks AlexTalks force-pushed the deflake_demo_decommission_cmd_test branch from 1f8e8f9 to cc1dd90 Compare August 8, 2023 23:10
@AlexTalks
Copy link
Contributor Author

bors r+

@craig
Copy link
Contributor

craig bot commented Aug 9, 2023

Build succeeded:

@craig craig bot merged commit 93546c2 into cockroachdb:master Aug 9, 2023
2 checks passed
@blathers-crl
Copy link

blathers-crl bot commented Aug 9, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from cc1dd90 to blathers/backport-release-22.1-107140: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.1.x failed. See errors above.


error creating merge commit from cc1dd90 to blathers/backport-release-22.2-107140: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.2.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-23.1.x Flags PRs that need to be backported to 23.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cli: TestDockerCLI flake [node incorrectly reports as draining]
4 participants