-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
acceptance: deflake test_demo_node_cmds #107140
acceptance: deflake test_demo_node_cmds #107140
Conversation
@AlexTalks Just noticed this - any reason not to merge it? |
Previously the acceptance test `test_demo_node_cmds`, which attempts to shutdown and decommission some nodes using the `cockroach demo` CLI, would sometimes be flaky due to delays in propagating information via gossip. This change fixes these flakes by utilizing the virtual table `crdb_internal.kv_node_liveness` rather than the gossip-based `gossip_liveness` virtual table. Fixes: cockroachdb#76391 Release note: None
Nope - will rebase and do so now! |
1f8e8f9
to
cc1dd90
Compare
bors r+ |
Build succeeded: |
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from cc1dd90 to blathers/backport-release-22.1-107140: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.1.x failed. See errors above. error creating merge commit from cc1dd90 to blathers/backport-release-22.2-107140: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.2.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Previously the acceptance test
test_demo_node_cmds
, which attempts to shutdown and decommission some nodes using thecockroach demo
CLI, would sometimes be flaky due to delays in propagating information via gossip. This change fixes these flakes by utilizing the virtual tablecrdb_internal.kv_node_liveness
rather than the gossip-basedgossip_liveness
virtual table.Fixes: #76391
Release note: None