New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: fix Sort dropdown on Latency page in db-console #107213
ui: fix Sort dropdown on Latency page in db-console #107213
Conversation
Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
This patch fixes selection of options in Sort dropdown that couldn't persist selected value because it triggered page reload with previous value via changes in history path. Release note (ui change): fix options selection in Sort dropdown on Latency page.
55711a4
to
173ab6b
Compare
Thank you for updating your pull request. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @gtr, @j82w, @xinhaoz, and @zachlite)
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 173ab6b to blathers/backport-release-22.2-107213: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.2.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
This patch fixes selection of options in Sort dropdown that couldn't persist selected value because it triggered page reload with previous value via changes in history path.
This bug is not present in master.
Release note (ui change): fix options selection in Sort dropdown on Latency page.
Epic: None
Screen.Recording.2023-07-20.at.01.04.43.mov