Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: fix Sort dropdown on Latency page in db-console #107213

Merged

Conversation

koorosh
Copy link
Collaborator

@koorosh koorosh commented Jul 19, 2023

This patch fixes selection of options in Sort dropdown that couldn't persist selected value because it triggered page reload with previous value via changes in history path.

This bug is not present in master.

Release note (ui change): fix options selection in Sort dropdown on Latency page.

Epic: None

Screen.Recording.2023-07-20.at.01.04.43.mov

@koorosh koorosh added the backport-22.2.x Flags PRs that need to be backported to 22.2. label Jul 19, 2023
@koorosh koorosh requested a review from a team as a code owner July 19, 2023 22:06
@blathers-crl
Copy link

blathers-crl bot commented Jul 19, 2023

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@blathers-crl blathers-crl bot added the O-community Originated from the community label Jul 19, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

This patch fixes selection of options in Sort dropdown that
couldn't persist selected value because it triggered page reload
with previous value via changes in history path.

Release note (ui change): fix options selection in Sort dropdown
on Latency page.
@koorosh koorosh force-pushed the ui-fix-sort-filter-on-latency-page branch from 55711a4 to 173ab6b Compare July 20, 2023 05:06
@blathers-crl
Copy link

blathers-crl bot commented Jul 20, 2023

Thank you for updating your pull request.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Copy link
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @gtr, @j82w, @xinhaoz, and @zachlite)

@koorosh koorosh merged commit a13f410 into cockroachdb:release-23.1 Jul 20, 2023
6 checks passed
@blathers-crl
Copy link

blathers-crl bot commented Jul 20, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 173ab6b to blathers/backport-release-22.2-107213: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.2.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-22.2.x Flags PRs that need to be backported to 22.2. O-community Originated from the community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants