New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-22.2: ui: fix Sort dropdown on Latency page in db-console #107295
Conversation
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to confirm, is the video on the PR for 22.2? Or was that imported from the 23.1 PR so not applicable?
I would like to confirm it working on 22.2
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @gtr, @j82w, @xinhaoz, and @zachlite)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This patch fixes selection of options in Sort dropdown that couldn't persist selected value because it triggered page reload with previous value via changes in history path. Release note (ui change): fix options selection in Sort dropdown on Latency page.
78944b1
to
0bbc5b2
Compare
Thank you for updating your pull request. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 4 files at r1, all commit messages.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @gtr, @j82w, @xinhaoz, and @zachlite)
Backport 1/1 commits from #107213.
/cc @cockroachdb/release
This patch fixes selection of options in Sort dropdown that couldn't persist selected value because it triggered page reload with previous value via changes in history path.
This bug is not present in master.
Release note (ui change): fix options selection in Sort dropdown on Latency page.
Release justification: low risk, high benefit changes to existing functionality
Epic: None
Screen.Recording.2023-07-22.at.10.29.37.mov