Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: ui: fix Sort dropdown on Latency page in db-console #107295

Merged
merged 1 commit into from Jul 28, 2023

Conversation

koorosh
Copy link
Collaborator

@koorosh koorosh commented Jul 20, 2023

Backport 1/1 commits from #107213.

/cc @cockroachdb/release


This patch fixes selection of options in Sort dropdown that couldn't persist selected value because it triggered page reload with previous value via changes in history path.

This bug is not present in master.

Release note (ui change): fix options selection in Sort dropdown on Latency page.

Release justification: low risk, high benefit changes to existing functionality

Epic: None

Screen.Recording.2023-07-22.at.10.29.37.mov

@blathers-crl
Copy link

blathers-crl bot commented Jul 20, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl
Copy link

blathers-crl bot commented Jul 20, 2023

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@blathers-crl blathers-crl bot added the O-community Originated from the community label Jul 20, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to confirm, is the video on the PR for 22.2? Or was that imported from the 23.1 PR so not applicable?
I would like to confirm it working on 22.2

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @gtr, @j82w, @xinhaoz, and @zachlite)

Copy link
Collaborator Author

@koorosh koorosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Updated video to show the result on 22.2 version.

Also this PR should be merged after this one #107176 to make tests pass.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @gtr, @j82w, @xinhaoz, and @zachlite)

This patch fixes selection of options in Sort dropdown that
couldn't persist selected value because it triggered page reload
with previous value via changes in history path.

Release note (ui change): fix options selection in Sort dropdown
on Latency page.
@blathers-crl
Copy link

blathers-crl bot commented Jul 26, 2023

Thank you for updating your pull request.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@koorosh koorosh requested a review from maryliag July 26, 2023 08:49
Copy link
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @gtr, @j82w, @xinhaoz, and @zachlite)

@koorosh koorosh merged commit 598950a into cockroachdb:release-22.2 Jul 28, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-community Originated from the community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants