c2c: teach event stream to decode and send span config updates #107400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
msbutler
changed the title
|
only the last commit is relevant. The first two are included in #107077 |
msbutler
force-pushed
the
butler-c2c-mr-zone
branch
from
acbc262
to
ec40f03
Compare
msbutler
commented
Jul 21, 2023
| // - delete a span config record | ||
| // - add several span config records in one accessor batch | ||
| // - update a subset of the tenant key space | ||
|
|
There was a problem hiding this comment.
noting to myself the additional test cases I want to add.
|
unrelated flakes |
This patch fixes a papercut where we were storing pointers to spans in the producer job proto. This isn't a correctness bug, as protocol buffers will dereference pointers to objects during unmarshalling, but rather, it seems dangerous to work with slices of pointers to spans. Release note: None
msbutler
force-pushed
the
butler-c2c-mr-zone
branch
5 times, most recently
from
bc2c83f
to
6979adb
Compare
If the user creates a stream client for span config updates, they will now receive span config updates in their subscription. Informs cockroachdb#106823 Release note: None
msbutler
force-pushed
the
butler-c2c-mr-zone
branch
from
6979adb
to
b36580f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user creates a stream client for span config updates, they will now
receive span config updates in their subscription.
Informs #106823
Release note: None