c2c: add CreateForSpanConfigs to the stream client #107077
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes a papercut where we were storing pointers to spans in the producer job proto. This isn't a correctness bug, as protocol buffers will dereference pointers to objects during unmarshalling, but rather, it seems dangerous to work with slices of pointers to spans. Release note: None
|
This change is |
msbutler
changed the title
msbutler
force-pushed
the
butler-c2c-new-plumbing
branch
2 times, most recently
from
88f4180
to
08d2dea
Compare
msbutler
requested review from
adityamaru,
stevendanna and
lidorcarmel
and removed request for
a team
This patch adds a new call to the stream client and the new `crdb_internal.start_span_config_replication_stream()` sql call which will begin a replication stream on the _system_ tenant's span configuration table to stream updates specific to the passed in application tenant. The ForSpanConfigs flag is now persisted to the producer job record to indicate this flavour of replication stream. A future PR will plumb this info through the StreamPartition spec. Informs cockroachdb#106823 Release note: None
msbutler
force-pushed
the
butler-c2c-new-plumbing
branch
from
08d2dea
to
d521615
Compare
|
closing in favor of #107671 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a new call to the stream client and the new
crdb_internal.start_span_config_replication_stream()sql call which willbegin a replication stream on the system tenant's span configuration table to
stream updates specific to the passed in application tenant. The ForSpanConfigs
flag is now persisted to the producer job record to indicate this flavour of
replication stream.
A future PR will plumb this info through the StreamPartition spec.
Informs #106823
Release note: None