kvserver: avoid moving parts in closedts tests #107613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This commit does a few things: - add "ManuallyReplicated" into aggressiveResolvedTimestampReplicatedClusterArgs - actually make that struct use `ReplicationMode: ReplicationManual` - go through all of the callers (visible via the rename) and set the replication mode to automatic again (with a TODO to be addressed in a follow-up commit) where it initially was, and remove explicitly setting it to manual where appropriate. In short, a no-op change but one that will be built upon next by allowing more of the callers to use the "manual" mode.
pickRandomTarget would livelock if there was only one replica. Now it panics, which is better.
tbg
force-pushed
the
closedts-test-use-manual
branch
from
6080df3
to
e3e9b77
Compare
erikgrinaker
approved these changes
Jul 27, 2023
|
bors r=erikgrinaker |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many tests (two just this last week12) are flaky because the replicate queue
can make rebalancing decisions that undermine the state the test is trying to
set up. Often, this happens "accidentally" because ReplicationAuto is our default
ReplicationMode.
This PR improves the situation at least for closed timestamp integration tests
by switching them all over to
ReplicationManual(and preventing any new onesfrom accidentally using
ReplicationAutoin the future).This can be seen as a small step towards #107528, which I am increasingly
convinced is an ocean worth boiling.
Epic: None
Release note: None
Footnotes
https://github.com/cockroachdb/cockroach/issues/107179 ↩
https://github.com/cockroachdb/cockroach/issues/101824 ↩