New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.1: cluster-ui: handle partial response errors on the database table page #110680
release-23.1: cluster-ui: handle partial response errors on the database table page #110680
Conversation
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like you're getting some test failures
Reviewable status: complete! 0 of 0 LGTMs obtained
Ah, it's because I forgot to backport #106778 opened a backport here: #110741 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 1 of 0 LGTMs obtained
Part of: cockroachdb#102386 This change applies the same error handling ideas from cockroachdb#109245 to the database table page, enabling non-admin users to use the database table page and providing better transparency to data fetching issues. `unavailable` fields provide a tooltip that displays the error impacting that field. Release note (ui change): Non-admin users are able to use the database table page.
0408c76
to
36c73da
Compare
Backport 1/1 commits from #109521.
/cc @cockroachdb/release
Part of: #102386
Demos (Note: these demos show this same logic applied to both the databases and database details pages as well):
DB-Console
This change applies the same error handling ideas from #109245 to the
database table page, enabling non-admin users to use the database table
page and providing better transparency to data fetching issues.
unavailable
fields provide a tooltip that displays the error impactingthat field.
Release note (ui change): Non-admin users are able to use the database
table page.
Release justification: UI improvement (regression fix)