Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.1: cluster-ui: handle partial response errors on the database table page #110680

Merged
merged 1 commit into from Sep 15, 2023

Conversation

THardy98
Copy link
Contributor

@THardy98 THardy98 commented Sep 14, 2023

Backport 1/1 commits from #109521.

/cc @cockroachdb/release


Part of: #102386

Demos (Note: these demos show this same logic applied to both the databases and database details pages as well):
DB-Console

This change applies the same error handling ideas from #109245 to the
database table page, enabling non-admin users to use the database table
page and providing better transparency to data fetching issues.

unavailable fields provide a tooltip that displays the error impacting
that field.

Release note (ui change): Non-admin users are able to use the database
table page.


Release justification: UI improvement (regression fix)

@THardy98 THardy98 requested review from maryliag and a team September 14, 2023 21:01
@THardy98 THardy98 requested a review from a team as a code owner September 14, 2023 21:01
@blathers-crl
Copy link

blathers-crl bot commented Sep 14, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Sep 14, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like you're getting some test failures

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained

@THardy98
Copy link
Contributor Author

THardy98 commented Sep 15, 2023

looks like you're getting some test failures

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained

Ah, it's because I forgot to backport #106778

opened a backport here: #110741

Copy link
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

Part of: cockroachdb#102386

This change applies the same error handling ideas from cockroachdb#109245 to the
database table page, enabling non-admin users to use the database table
page and providing better transparency to data fetching issues.

`unavailable` fields provide a tooltip that displays the error impacting
that field.

Release note (ui change): Non-admin users are able to use the database
table page.
@THardy98 THardy98 merged commit e55e071 into cockroachdb:release-23.1 Sep 15, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants