sql/copy: fix planning for vectorized COPY with nested renderNodes #111284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
A COPY insert statement can produce a plan with zero or more renderNodes and we were only allowing zero or one. An example of multiple render nodes is a table with a hash shared primary key. Fixes: cockroachdb#104662 Release note (sql change): Vectorized COPY FROM support didn't properly handle schemas hash sharded primary keys. Epic: none
Instead of names like TestDataDriven/copy_test#0 we can now use names like: TestDataDriven/copy_test/vectorize=off/atomic=on/fastPath=on/copy_from Epic: none Release note: None
cucaroach
requested review from
msirek and
yuzefovich
and removed request for
a team and
msirek
yuzefovich
added
the
backport-23.1.x
yuzefovich
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
Nice find!
Reviewed 3 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @cucaroach)
|
bors r+ |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 872ceb9 to blathers/backport-release-23.1-111284: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A COPY insert statement can produce a plan with zero or more renderNodes
and we were only allowing zero or one. An example of multiple render
nodes is a table with a hash shared primary key.
Fixes: #104662
Release note (sql change): Vectorized COPY FROM support didn't properly
handle schemas hash sharded primary keys.
Epic: none