Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.1: sql/copy: fix planning for vectorized COPY with nested renderNodes #111412

Merged
merged 1 commit into from Oct 2, 2023
Merged

release-23.1: sql/copy: fix planning for vectorized COPY with nested renderNodes #111412

merged 1 commit into from Oct 2, 2023

Conversation

cucaroach
Copy link
Contributor

@cucaroach cucaroach commented Sep 28, 2023 •
edited

Backport 1/2 commits from #111284.

/cc @cockroachdb/release

A COPY insert statement can produce a plan with zero or more renderNodes
and we were only allowing zero or one. An example of multiple render
nodes is a table with a hash shared primary key.

Fixes: #104662
Release note (sql change): Vectorized COPY FROM support didn't properly
handle schemas hash sharded primary keys.
Epic: none

Release justification: fix for regression in COPY with hash sharded tables.

@cucaroach cucaroach requested a review from a team as a code owner September 28, 2023 13:09
@cucaroach cucaroach requested review from rharding6373 and removed request for a team September 28, 2023 13:09
@blathers-crl
Copy link

blathers-crl bot commented Sep 28, 2023 •
edited by cucaroach

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Sep 28, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

yuzefovich
yuzefovich approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @rharding6373)

@cucaroach
sql/copy: fix planning for vectorized COPY with nested renderNodes
6f869aa 
A COPY insert statement can produce a plan with zero or more renderNodes
and we were only allowing zero or one. An example of multiple render
nodes is a table with a hash shared primary key.

Fixes: cockroachdb#104662
Release note (sql change): Vectorized COPY FROM support didn't properly
handle schemas hash sharded primary keys.
Epic: none

Release justification: fix for regression in COPY with hash sharded tables.
rharding6373
rharding6373 approved these changes Sep 28, 2023
View reviewed changes
Copy link
Collaborator

@rharding6373 rharding6373 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @cucaroach)

@cucaroach cucaroach merged commit 54bf017 into cockroachdb:release-23.1 Oct 2, 2023
6 checks passed
@cucaroach cucaroach deleted the backport23.1-111284 branch October 2, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuzefovich yuzefovich yuzefovich approved these changes

@rharding6373 rharding6373 rharding6373 approved these changes

Assignees
No one assigned
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cucaroach @cockroach-teamcity @yuzefovich @rharding6373