release-23.2: cli: add job traces for traceable jobs to the debug zip #112644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers-crl[bot]](https://avatars.githubusercontent.com/in/59700?s=60&v=4){kind=small}
Release note: None
This change teaches the debug zip to collect the traces for traceable jobs (backup, restore, import, pcr) that are in a running or reverting state at the time the zip is collected. These traces are dumped in a `/jobs/<jobID>/<timestamp>/trace.zip` file and rely on the existing `tracing/zippr` that is used by `cockroach debug job-trace` to collect the required information. Note this functionality is default off. Release note (cli change): `cockroach debug zip` has an additional flag that is default off `include-running-job-traces` that will enable collecting the inflight traces of traceable jobs such as backup, restore, import, c2c and dump them in a `jobs/` subdirectory in the zip.
blathers-crl
bot
force-pushed
the
blathers/backport-release-23.2-112130
branch
from
1b00425
to
bd82c40
Compare
blathers-crl
bot
requested review from
msbutler
and removed request for
a team
blathers-crl
bot
added
the
blathers-backport
blathers-crl
bot
force-pushed
the
blathers/backport-release-23.2-112130
branch
from
899463a
to
11daaa7
Compare
blathers-crl
bot
requested review from
dhartunian
and removed request for
a team
|
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
blathers-crl
bot
added
the
backport
|
This change is |
adityamaru
requested review from
dt and
stevendanna
and removed request for
msbutler and
dhartunian
dt
approved these changes
Oct 18, 2023
|
test timeout in TestRevertTenantToTimestamp is unrelated, ill track that separately. It might just be one of the infra timeouts we've seen today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 2/2 commits from #112130 on behalf of @adityamaru.
/cc @cockroachdb/release
This change teaches the debug zip to collect the traces for traceable jobs (backup, restore, import, pcr) that are in a running or reverting state at the time the zip is collected. These traces are dumped in a
/jobs/<jobID>/<timestamp>/trace.zipfile and rely on the existingtracing/zipprthat is used bycockroach debug job-traceto collect the required information.Informs: #111886
Release note (cli change):
cockroach debug zipcan now collect the inflight traces of traceable jobs such as backup, restore, import, c2c and dump them in ajobs/subdirectory in the zip.Release justification: debug only functionality that defaults to disabled, and can be used to investigate stuck or slow jobs