Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backupccl: grab periodic job profiles in DR roachtests #111886

Open
msbutler opened this issue Oct 6, 2023 · 1 comment
Open

backupccl: grab periodic job profiles in DR roachtests #111886

msbutler opened this issue Oct 6, 2023 · 1 comment
Labels
A-disaster-recovery C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) stability-period Intended to be worked on during a stability period. Use with the Milestone field to specify version. T-disaster-recovery
Projects
Disaster Recovery Backlog

Comments

@msbutler
Copy link
Collaborator

msbutler commented Oct 6, 2023 •
edited by exalate-issue-sync bot

We ought grab periodic job profiles in all DR roachtests for two reasons:

  • ensure they do not affect job performance or stability
  • use them for debugging (they should be dumped to the artifacts directory)

Jira issue: CRDB-32111

Epic CRDB-31689
@msbutler msbutler added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-disaster-recovery stability-period Intended to be worked on during a stability period. Use with the Milestone field to specify version. labels Oct 6, 2023
@blathers-crl
Copy link

blathers-crl bot commented Oct 6, 2023

cc @cockroachdb/disaster-recovery

@blathers-crl blathers-crl bot added this to Triage in Disaster Recovery Backlog Oct 6, 2023
@adityamaru adityamaru mentioned this issue Oct 10, 2023
Merged
craig bot pushed a commit that referenced this issue Oct 18, 2023
@adityamaru @rafiss
Merge #112130 #112624
2cb7c2a 
112130: cli: add job traces for traceable jobs to the debug zip r=adityamaru a=adityamaru

This change teaches the debug zip to collect the traces for traceable jobs (backup, restore, import, pcr) that are in a running or reverting state at the time the zip is collected. These traces are dumped in a
`/jobs/<jobID>/<timestamp>/trace.zip` file and rely on the existing `tracing/zippr` that is used by
`cockroach debug job-trace` to collect the required information.

Informs: #111886
Release note (cli change): `cockroach debug zip` will now collect the inflight traces of traceable jobs such as backup, restore, import, c2c and dump them in a `jobs/` subdirectory in the zip.

112624: logictest: disable metamorphic testing for mixed version test r=rafiss a=rafiss

We've seen that these tests can get quite slow sometimes. One theory is that this is caused by metamorphic test settings, so this PR disables them so we can determine if it helps with test stability.

informs #112621
Release note: None

Co-authored-by: adityamaru <adityamaru@gmail.com>
Co-authored-by: Rafi Shamim <rafi@cockroachlabs.com>
@blathers-crl blathers-crl bot mentioned this issue Oct 18, 2023
Merged
@adityamaru adityamaru removed their assignment Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-disaster-recovery C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) stability-period Intended to be worked on during a stability period. Use with the Milestone field to specify version. T-disaster-recovery
Projects
Disaster Recovery Backlog
Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adityamaru @msbutler